Bump Django version to 3.0 and set PyMySQL version #3248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
busunkim96
reviewed
Apr 1, 2020
| @@ -1,2 +1,2 @@ | |||
| Django==2.1.14 #This requirement must remain pinned at 2.1.14 until https://github.com/PyMySQL/PyMySQL/issues/790 is resolved | |||
| Django==3.0.5 #This requirement must remain pinned at 2.1.14 until https://github.com/PyMySQL/PyMySQL/issues/790 is resolved | |||
There was a problem hiding this comment.
Should the note about pinning at 2.1.14 be removed?
There was a problem hiding this comment.
Yeah, it definitely should. Removed.
busunkim96
approved these changes
Apr 1, 2020
kurtisvg
approved these changes
Apr 1, 2020
leahecole
approved these changes
Apr 1, 2020
leahecole
added
the
automerge
Closed
1 task
busunkim96
pushed a commit
to busunkim96/python-docs-samples
that referenced
this pull request
Apr 2, 2020
…rm#3248) Alternative to GoogleCloudPlatform#3244 to continue PyMySQL support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #3244 to continue PyMySQL support