Skip to content

update iap to use google-auth for id_token #3444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Apr 23, 2020
Merged

update iap to use google-auth for id_token #3444

merged 17 commits into from
Apr 23, 2020

Conversation

arithmetic1728
Copy link
Contributor

No description provided.

@arithmetic1728 arithmetic1728 requested a review from a team as a code owner April 20, 2020 21:26
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 20, 2020
@arithmetic1728 arithmetic1728 marked this pull request as draft April 20, 2020 21:26
@arithmetic1728 arithmetic1728 mentioned this pull request Apr 21, 2020
Merged
gguuss
gguuss approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a language perspective, maybe get @ace-n to review from the perspective of product and let us know when it's ready.

@arithmetic1728
Copy link
Contributor Author

@gguuss Thank you!

@bshaffer Could you take a look at the implementation?

@arithmetic1728 arithmetic1728 marked this pull request as ready for review April 22, 2020 22:22
@gguuss gguuss assigned bshaffer and unassigned gguuss Apr 22, 2020
bshaffer
bshaffer approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran these samples with my own client ID and URL, and everything worked as expected. Well done!

@bshaffer bshaffer merged commit 5ef84ba into GoogleCloudPlatform:master Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bshaffer bshaffer bshaffer approved these changes

@gguuss gguuss gguuss approved these changes

Assignees

@bshaffer bshaffer

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arithmetic1728 @bshaffer @gguuss @googlebot