Skip to content

docs(storage): add samples for lifer cycle and versioning #3578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 4, 2020
Merged

docs(storage): add samples for lifer cycle and versioning #3578

merged 5 commits into from
May 4, 2020

Conversation

HemangChothani
Copy link
Contributor

Added Samples For

  • Enable, Disable Versioning

  • Enable,Disable life cycle management

  • Set blob metadata

@HemangChothani HemangChothani requested review from crwilcox and a team as code owners April 29, 2020 12:38
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 29, 2020
tmatsuo
tmatsuo approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@tmatsuo tmatsuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no concerns on test quality.

@leahecole leahecole requested a review from frankyn May 1, 2020 04:27
@leahecole
Copy link
Collaborator

@frankyn or @crwilcox I'd like your eyes on this before I do the final stamp - just want to make sure it looks good from a storage standpoint

frankyn
frankyn approved these changes May 1, 2020
View reviewed changes
Copy link
Contributor

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HemangChothani LGTM!

@frankyn frankyn added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 4, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 4, 2020
@frankyn frankyn merged commit 4d4147d into GoogleCloudPlatform:master May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmatsuo tmatsuo tmatsuo approved these changes

@frankyn frankyn frankyn approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees

@leahecole leahecole

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@HemangChothani @leahecole @tmatsuo @frankyn @googlebot @kokoro-team