Skip to content

Update docker image used for tests #3834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 20, 2020
Merged

Update docker image used for tests #3834

merged 2 commits into from
May 20, 2020

Conversation

shubha-rajan
Copy link
Contributor

Updating kokoro build configs to use the image from PR #3776
Towards #3442

@shubha-rajan shubha-rajan requested a review from a team as a code owner May 19, 2020 20:38
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 19, 2020
@shubha-rajan shubha-rajan requested review from tmatsuo and kurtisvg May 19, 2020 20:39
tmatsuo
tmatsuo reviewed May 19, 2020
View reviewed changes
Copy link
Contributor

@tmatsuo tmatsuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to add the tag part?

kurtisvg
kurtisvg approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@kurtisvg kurtisvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's wait for the continuous build to finish before merging

@kurtisvg kurtisvg mentioned this pull request May 19, 2020
Merged
@shubha-rajan shubha-rajan added the automerge Merge the pull request once unit tests and other checks pass. label May 20, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 4b5d28b into GoogleCloudPlatform:master May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmatsuo tmatsuo tmatsuo approved these changes

@kurtisvg kurtisvg kurtisvg approved these changes

Assignees

@crwilcox crwilcox

Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shubha-rajan @tmatsuo @kurtisvg @crwilcox @googlebot