Skip to content

testing: various cleanups #3879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2020

Conversation

tmatsuo
Copy link
Contributor

@tmatsuo tmatsuo commented May 26, 2020

  • activate the secret service account only when the key is there
  • merge automl_secrets.txt into test-env.sh
  • if .kokoro/docker or .kokoro/tests have changes, test everything
  • remove stale apt-get command
  • use SECRET_MANAGER_PROJECT envvar for secret manager command,
    fallback to cloud-devrel-kokoro-resources

fixes #3820

* activate the secret service account only when the key is there
* merge automl_secrets.txt into test-env.sh
* if .kokoro/docker or .kokoro/tests have changes, test everything
* remove stale apt-get command
* use SECRET_MANAGER_PROJECT envvar for secret manager command,
  fallback to cloud-devrel-kokoro-resources
@tmatsuo tmatsuo requested review from busunkim96 and kurtisvg May 26, 2020 17:45
@tmatsuo tmatsuo requested a review from a team as a code owner May 26, 2020 17:45
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 26, 2020
@busunkim96
Copy link
Contributor

Is the Bigquery failure a flake?


Test
natality_tutorial_test.test_natality_tutorial

Run time 0:00:00.473
Failed: google.api_core.exceptions.PreconditionFailed: 412 POST https://bigquery.googleapis.com/bigquery/v2/projects/python-docs-samples-tests/datasets: IAM setPolicy failed for Dataset python-docs-samples-tests:natality_regression_6f9938f5_60fe_47c0_9424_41d8d1b3db7a: There were concurrent policy changes. Please retry the whole read-modify-write with exponential backoff.
Traceback (most recent call last):
  File "/tmpfs/src/github/python-docs-samples/bigquery/cloud-client/natality_tutorial_test.py", line 42, in test_natality_tutorial
    natality_tutorial.run_natality_tutorial(override_values)
  File "/tmpfs/src/github/python-docs-samples/bigquery/cloud-client/natality_tutorial.py", line 50, in run_natality_tutorial
    dataset = client.create_dataset(dataset)
  File "/tmpfs/src/github/python-docs-samples/bigquery/cloud-client/.nox/py-3-7/lib/python3.7/site-packages/google/cloud/bigquery/client.py", line 461, in create_dataset
    retry, method="POST", path=path, data=data, timeout=timeout
  File "/tmpfs/src/github/python-docs-samples/bigquery/cloud-client/.nox/py-3-7/lib/python3.7/site-packages/google/cloud/bigquery/client.py", line 556, in _call_api
    return call()
  File "/tmpfs/src/github/python-docs-samples/bigquery/cloud-client/.nox/py-3-7/lib/python3.7/site-packages/google/api_core/retry.py", line 286, in retry_wrapped_func
    on_error=on_error,
  File "/tmpfs/src/github/python-docs-samples/bigquery/cloud-client/.nox/py-3-7/lib/python3.7/site-packages/google/api_core/retry.py", line 184, in retry_target
    return target()
  File "/tmpfs/src/github/python-docs-samples/bigquery/cloud-client/.nox/py-3-7/lib/python3.7/site-packages/google/cloud/_http.py", line 423, in api_request
    raise exceptions.from_http_response(response)
google.api_core.exceptions.PreconditionFailed: 412 POST https://bigquery.googleapis.com/bigquery/v2/projects/python-docs-samples-tests/datasets: IAM setPolicy failed for Dataset python-docs-samples-tests:natality_regression_6f9938f5_60fe_47c0_9424_41d8d1b3db7a: There were concurrent policy changes. Please retry the whole read-modify-write with exponential backoff.

@tmatsuo
Copy link
Contributor Author

tmatsuo commented May 26, 2020

@busunkim96 I filed it as a flake at #3882

@tmatsuo
Copy link
Contributor Author

tmatsuo commented May 26, 2020

There's a failure, but it's a kind of flakes. The flake is reported. I'm going to merge this with admin power.

@tmatsuo tmatsuo merged commit 23f45bc into GoogleCloudPlatform:master May 26, 2020
@tmatsuo tmatsuo deleted the run-tests-cleanup branch May 26, 2020 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cleanup: remove stale code in run_tests.sh
4 participants