-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New directory for OpenTelemetry QuickStart #4016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New directory for OpenTelemetry QuickStart #4016
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@aravinsiva If you are a Googler, make sure to register your GitHub account with Google Open Source. If you're an external contributor, please sign the CLA. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from my end. I assume there's still work pending before this can be merged? (the -e ...
installs in the requirements.txt
)
…iva/python-docs-samples into porting_to_opentelemetry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One outstanding comment, otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM since @sjbrunst is happy
Most files are the same from cloud-trace-demo-app. The ones that have been modified to support the opentelemetry framework are as follows:
Corresponding QuickStart docs can be found here:
(https://cloud.google.com/trace/docs/quickstart