Skip to content

chore(servicedirectory): add region tags #4403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 4, 2020

Conversation

rebeccawshaw
Copy link
Contributor

@rebeccawshaw rebeccawshaw commented Jul 31, 2020

add region tags to so we can upload code snippets in our docs: https://cloud.devsite.corp.google.com/service-directory/docs/configuring-service-directory

Description

Fixes #

Note: It's a good idea to open an issue first for discussion.

Checklist

@rebeccawshaw rebeccawshaw requested a review from a team as a code owner July 31, 2020 08:41
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 31, 2020
add region tags for quickstart.py to add the code to our documentation
fix spacing
@busunkim96 busunkim96 added the blunderbuss: assign Instruct blunderbuss to assign someone label Aug 3, 2020
@blunderbuss-gcf blunderbuss-gcf bot removed the blunderbuss: assign Instruct blunderbuss to assign someone label Aug 3, 2020
@tmatsuo tmatsuo changed the title add region tags chore(servicedirectory): add region tags Aug 3, 2020
@tmatsuo
Copy link
Contributor

tmatsuo commented Aug 4, 2020

@rebeccawshaw

Consider joining GoogleCloudPlatform org so that your pull request will automatically trigger the CI builds.

@tmatsuo tmatsuo added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 4, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 4, 2020
@tmatsuo tmatsuo merged commit 945de0c into GoogleCloudPlatform:master Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants