Skip to content

feat: add Dataproc-Composer tutorial #4485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Sep 14, 2020
Merged

feat: add Dataproc-Composer tutorial #4485

merged 15 commits into from
Sep 14, 2020

Conversation

sofisl
Copy link
Contributor

@sofisl sofisl commented Aug 12, 2020

@bradmiro and I are working on a Composer Dataproc tutorial:

https://docs.google.com/document/d/1xcOzEmnY9hjaGtUCmvFfQRsPF2Hbw49rbPcYu6JoPm0/edit?usp=sharing

Adding in the DAG sample for the tutorial here.

@sofisl sofisl requested review from leahecole and a team as code owners August 12, 2020 03:05
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 12, 2020
@bradmiro bradmiro self-assigned this Aug 13, 2020
@engelke engelke assigned leahecole and unassigned engelke Aug 13, 2020
@bradmiro bradmiro added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 14, 2020
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Aug 21, 2020
@bradmiro bradmiro removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 27, 2020
Copy link
Collaborator

@leahecole leahecole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Silliest lil nit, otherwise, LGTM. I'm going through the CL now

# DAG object.
with models.DAG(
# The id you will see in the DAG airflow page
"dataproc_dag",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit - should we give this a more descriptive name? Perhaps dataproc_workflow_dag?

@sofisl sofisl requested a review from leahecole September 3, 2020 19:04
Copy link
Collaborator

@leahecole leahecole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! love an example!

@leahecole leahecole merged commit ba89f77 into master Sep 14, 2020
@leahecole leahecole deleted the addDataprocTutorial branch September 14, 2020 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants