-
Notifications
You must be signed in to change notification settings - Fork 6.5k
feat: add Dataproc-Composer tutorial #4485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Silliest lil nit, otherwise, LGTM. I'm going through the CL now
# DAG object. | ||
with models.DAG( | ||
# The id you will see in the DAG airflow page | ||
"dataproc_dag", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit - should we give this a more descriptive name? Perhaps dataproc_workflow_dag
?
…python-docs-samples into addDataprocTutorial
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! love an example!
@bradmiro and I are working on a Composer Dataproc tutorial:
https://docs.google.com/document/d/1xcOzEmnY9hjaGtUCmvFfQRsPF2Hbw49rbPcYu6JoPm0/edit?usp=sharing
Adding in the DAG sample for the tutorial here.