Skip to content

added cloudevents to events-storage #4537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cumason123
Copy link
Contributor

Signed-off-by: Curtis Mason [email protected]

Description

Fixes #4531

Note: It's a good idea to open an issue first for discussion.

Checklist

Curtis Mason added 2 commits August 20, 2020 18:06
Signed-off-by: Curtis Mason <[email protected]>
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 20, 2020
Signed-off-by: Curtis Mason <[email protected]>
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Aug 21, 2020
@grant
Copy link
Contributor

grant commented Aug 21, 2020

LGTM!

@google-cla
Copy link

google-cla bot commented Aug 27, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Aug 27, 2020
@leahecole leahecole added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Aug 27, 2020
@leahecole
Copy link
Collaborator

Author was an intern when they wrote the code and. had signed the CLA

@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 27, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 27, 2020
@leahecole leahecole merged commit 4fba45f into GoogleCloudPlatform:master Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloud Run events samples should use sdk-python cloudevents
6 participants