-
Notifications
You must be signed in to change notification settings - Fork 6.5k
feat: python version of idp-sql tutorial #5315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Here is the summary of changes. You are about to add 3 region tags.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few thoughts:
- Is there an idiomatic way to split main.py into separate files to reduce complexity?
- A priority is to add a sig term handler to show of that functionality (depending on this postgres library, the db connections can be closed when sigterm is caught)
- A lesser priority would be to implement better logging. In order for stackdriver to parse the logs correctly they need to be json formatted with a severity property to set for the log level to be parsed.
As discussed with @averikitsch, this now uses NullPool when testing only to work around service delete issues; will re-address when upstream changes happen around those. I'm comfortable with this PR being merged as it is. (I have the ability to hit the [squash and merge] button with the approvals received, but I'm not sure if I should be merging my own PRs) |
LGTM. Feel free to merge |
Description
Checklist
nox -s py-3.6
(see Test Environment Setup)nox -s lint
(see Test Environment Setup)