Skip to content

Add bigquery shakespeare example #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 6, 2016
Merged

Add bigquery shakespeare example #604

merged 3 commits into from
Dec 6, 2016

Conversation

theacodes
Copy link
Contributor

No description provided.

Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for doing this.

@theacodes theacodes added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 21, 2016
@theacodes
Copy link
Contributor Author

@tswast thanks, currently unmergable due to googleapis/google-cloud-python#2585

@tswast
Copy link
Contributor

tswast commented Oct 21, 2016

Ugh.

def test_query_shakespeare(capsys):
simple_app.query_shakespeare()
out, _ = capsys.readouterr()
assert 'Hamlet' in out
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'hamlet' is lower-case in my query output in the Java sample I'm writing.

titles:
    hamlet: 5318
    kinghenryv: 5104
    cymbeline: 4875
    troilusandcressida: 4795
    kinglear: 4784
    kingrichardiii: 4713
    2kinghenryvi: 4683
    coriolanus: 4653
    2kinghenryiv: 4605
    antonyandcleopatra: 4582
total unique words: 164656

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the heads up.

Jon Wayne Parrott added 2 commits December 6, 2016 13:07
Change-Id: I72c8daab71486d808947ddf0a5ae797e8f3bfa62
Change-Id: Ice67b76ff89f83c289ffefb6a5981166a0b71fcc
@theacodes theacodes force-pushed the bigquery-shakespeare branch from 176f161 to e6971e1 Compare December 6, 2016 21:22
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 6, 2016
Change-Id: I7d3d3a550159c5acb261cc0b2caf02ceaa7b25eb
@theacodes theacodes merged commit c4a1411 into master Dec 6, 2016
@theacodes theacodes deleted the bigquery-shakespeare branch December 6, 2016 21:56
shollyman pushed a commit to googleapis/python-bigquery that referenced this pull request Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants