refactor: update typehints for servicedirectory samples #9969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
samples
engelke
reviewed
May 16, 2023
| @@ -17,24 +17,24 @@ | |||
| from os import environ | |||
| import uuid | |||
|
|
|||
| from _pytest.capture import CaptureFixture | |||
There was a problem hiding this comment.
Prefer testing a response instead of captured output. Functions that just print a message can return a status indicating success or failure.
engelke
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
b/280879439 : Update typehints for service directory samples.
Checklist
nox -s py-3.9(see Test Environment Setup)nox -s lint(see Test Environment Setup)