Skip to content

Expose #deleteFromCacheByFields #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 4, 2021
Merged

Conversation

bitops
Copy link
Contributor

@bitops bitops commented Aug 22, 2021

A PR for this issue. Thanks so much!

@bitops
Copy link
Contributor Author

bitops commented Aug 22, 2021

@lorensr this fills a big need for me in the API so all feedback welcome!

@bitops
Copy link
Contributor Author

bitops commented Aug 31, 2021

@lorensr any feedback on this PR? If you think this PR is looking good I am glad to try and give this bug another attempt next after this gets merged. (Also, I left you an implementation question on that findByFields issue.)

@lorensr lorensr merged commit e105344 into GraphQLGuide:master Sep 4, 2021
@lorensr
Copy link
Member

lorensr commented Sep 4, 2021

Thanks a lot! I edited your code a little, as well as making a number of other changes in this commit: 90411e3

@bitops
Copy link
Contributor Author

bitops commented Sep 4, 2021

@lorensr a-okay with me! I am glad to see the contribution make it in. Thank you accepting it. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants