Skip to content

TypeReference improvements #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 12, 2022
Merged

TypeReference improvements #108

merged 2 commits into from
Oct 12, 2022

Conversation

NeedleInAJayStack
Copy link
Member

@NeedleInAJayStack NeedleInAJayStack commented Sep 30, 2022 •
edited
Loading

This PR adds enhances TypeReference handling in the following ways:

  1. Changes logic to ensure that TypeReferences are replaced during typeMapReduction
  2. Adds logic to ensure that all TypeReferences in instantiated Schemas have been replaced by the actual types. In the case where they are not, the schema initalizer throws an error.

Tests are added too

@NeedleInAJayStack NeedleInAJayStack force-pushed the feature/type-reference-imrovements branch 2 times, most recently from cf6d660 to 64669a7 Compare September 30, 2022 19:43
@NeedleInAJayStack NeedleInAJayStack force-pushed the feature/type-reference-imrovements branch from 7835a2d to d6a94dd Compare October 11, 2022 19:13
@paulofaria
Copy link
Member

Is this good to go?

@NeedleInAJayStack
Copy link
Member Author

Yup, all set! Thanks Paulo!

paulofaria
paulofaria approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@paulofaria paulofaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Jay! 🙂

@NeedleInAJayStack NeedleInAJayStack merged commit dda63e4 into GraphQLSwift:main Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulofaria paulofaria paulofaria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NeedleInAJayStack @paulofaria