Port Printer from graphql-js #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samisuteria
commented
Oct 12, 2023
| ast.printed | ||
| } | ||
|
|
||
| private protocol Printable { |
There was a problem hiding this comment.
I created this protocol instead of using CustomStringConvertible because some of the nodes already have a variable called description and it was clashing.
NeedleInAJayStack
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported printer functions from https://github.com/graphql/graphql-js/blob/main/src/language/printer.ts with the goal of using it with federation features. Currently users need to use
.setFederatedSDL(to: <String>)in the schema builder in Graphiti and this feels like a step toward removing that requirement.Still need to port printString and printBlockString functions from the js implementation but that ran into some complications and I would prefer to do that in a future PR.
I'm still unsure about how to expose this in Graphiti and get the document type to
GraphQLSchema.