-
Notifications
You must be signed in to change notification settings - Fork 73
Visitor Fixes and Editing Support #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visitor Fixes and Editing Support #134
Conversation
Also brings into alignment with graphql-js
@paulofaria Looks like the |
Hm, I'm not sure we can, based on the SSWG guidelines? Can't we just remove the keyword so it's backwards compatible? |
0eaa800
to
c1cae12
Compare
Oh weird - I added Maybe not relevant anymore, but I don't think SSWG requires extensive backsupport - New NIO versions only back-support to Swift 5.7: https://github.com/apple/swift-nio/#swiftnio-2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful!
Thanks @paulofaria. I just made one last small change to back-support the public Node Protocol API, making this a minor change instead of major. Mind approving again? |
This adds editing support to the AST Visitor system. In addition, it also: