Swift 4.2 #43
Closed
Swift 4.2 #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting a Runtime framework crash on Swift 4.2; the author updated the framework and the crash seems to have been fixed. This PR:
Package.swiftto point to Runtime'sswift-42branch, although if it gets merged tomaster, it should probably point to that.numThreadstonumberOfThreads.Some of the tests are failing, but it looks like they were failing under Swift 4.1, as well.
It might make sense to create a
swift-42branch in this repo as well, until it leaves beta.Edit: I think the Xcode 10 beta will need to be added to Travis, and possibly installed on the machine as well.