-
Notifications
You must be signed in to change notification settings - Fork 73
Adds support for reference types on Input fields #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for reference types on Input fields #78
Conversation
Renames some Input field types for consistency with output field types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Feel free to merge and tag it! 🙂
@paulofaria Thanks for the review! I'm happy to merge and tag it, but I think I need to be given write access to this repo to do so... |
@paulofaria Hey, just a reminder that I'm happy to merge and tag, but I don't have write access. Any chance you could provide me with it? |
Hey! I'll do that Today. Sorry. |
@alexsteinerde Did you receive the invitation? |
@alexsteinerde Sorry, the message was meant for @NeedleInAJayStack. |
@NeedleInAJayStack I created a Maintainers team. You should now have access to all repos. 😄 |
Awesome, I do have access now! Thanks @paulofaria |
@paulofaria I added 'macos-latest' to the CI build file so that we won't run into PR "status check" issues in the future. However, the commit reset the approval. Do you mind re-approving this? |
Done! |
This adds support for recursive inputs (inputs that reference themselves). For example, the following is now a valid input definition:
This builds on the Type and Interface recursion support (via
TypeReference
), by extending that functionality to Inputs as well.It also renames a few Input Field types to be more consistent with the equivalent Type Field types