Skip to content

Adds support for reference types on Input fields #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

NeedleInAJayStack
Copy link
Member

This adds support for recursive inputs (inputs that reference themselves). For example, the following is now a valid input definition:

input BoolExp {
  and: [BoolExp]
  or: [BoolExp]
  val: Bool
}

This builds on the Type and Interface recursion support (via TypeReference), by extending that functionality to Inputs as well.

It also renames a few Input Field types to be more consistent with the equivalent Type Field types

Renames some Input field types for consistency with output field types
paulofaria
paulofaria previously approved these changes Apr 21, 2021
Copy link
Member

@paulofaria paulofaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Feel free to merge and tag it! 🙂

@NeedleInAJayStack
Copy link
Member Author

@paulofaria Thanks for the review! I'm happy to merge and tag it, but I think I need to be given write access to this repo to do so...

@NeedleInAJayStack
Copy link
Member Author

@paulofaria Hey, just a reminder that I'm happy to merge and tag, but I don't have write access. Any chance you could provide me with it?

@paulofaria
Copy link
Member

Hey! I'll do that Today. Sorry.

@paulofaria
Copy link
Member

@alexsteinerde Did you receive the invitation?

@paulofaria
Copy link
Member

@alexsteinerde Sorry, the message was meant for @NeedleInAJayStack.

@paulofaria
Copy link
Member

@NeedleInAJayStack I created a Maintainers team. You should now have access to all repos. 😄

@NeedleInAJayStack
Copy link
Member Author

Awesome, I do have access now! Thanks @paulofaria

@NeedleInAJayStack
Copy link
Member Author

@paulofaria I added 'macos-latest' to the CI build file so that we won't run into PR "status check" issues in the future. However, the commit reset the approval. Do you mind re-approving this?

@paulofaria
Copy link
Member

Done!

@NeedleInAJayStack NeedleInAJayStack merged commit 7aa6430 into GraphQLSwift:master May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants