Add working Linux tests #81
Conversation
|
The thread sanitizer is complaining. |
|
Removed the thread sanitizer. Issues are with Runtime package and cannot be resolved here. I've added an issue wickwirew/Runtime#87 |
|
Is there any reason GraphQL doesn't use |
|
Back then, Mirror wasn't powerful enough! Do you reckon it is possible to replace Runtime with Mirror? I haven't heard of any updates regarding reflection in Swift. I'd love to simplify the codebase and remove the dependency, if possible. |
All you seem to be using it for is extracting values out of a type using the variable name. I'll add a PR to demonstrate |
|
@adam-fowler I think updating from master should solve the issue with GH actions. |
|
Basically adding the macos-latest? |
|
@paulofaria This change will need a change to the required tests. The ubuntu tests you had before didn't test anything. This is why I added this PR. But the change uses the swift docker images which have different names to the ubuntu images required at the moment. The swift docker images are better to use because we can be specific about which version of swift we want running. As an aside isn't macos-10.15 the same as macos-latest? |
|
As an aside isn't macos-10.15 the same as macos-latest? @adam-fowler Yeah, I think so. @alexsteinerde might chime in and let us know why adding "macos-latest" fixes the GH actions stall issue. If changing to "macos-latest" and removing macos-10.15 works, I'm cool with just using "macos-latest". |
|
@adam-fowler With this change, should we remove the ubuntu items from this line in the existing workflow yml? |
|
Looks like it needs updated to support 5.5 and 5.6. Although since I posted the new swift install actions are available which could simplify this more. I'll rebuild this using them. |
Issues are with Runtime package and can't be fixed in GraphQL
Since Swift 5.4 it is not a requirement
It appears the codeclimate-action messes with the swift setup
|
Can we get rid of the required tests |
|
Added @NeedleInAJayStack to the admins team. He should have full access now. |
|
Closed by accident. |
|
Hm, not sure how I can get rid of that? Maybe we should force merge, then that requirement will be gone, since it won't be in the yml file anymore? This looks like a GH bug, I reckon. |
It is in the settings for the project (something only admins can access). Do you have branch protection setup? |
|
I've removed |
|
Scratch that - I've changed the branch protection rules to be the actions that ran when this was merged to master. Specifically, the actions required are:
Thanks for this work @adam-fowler! |
|
I think it's pretty pointless adding required builds. You already require an admin approval. Also the required builds will change overtime as new versions of swift are released. Swift NIO is only ever planning to support the last three versions of swift so there is no real point for a project reliant of NIO trying to support more version of swift than that. So when 5.7 is released support for 5.4 won't be required. Of course you can still support 5.4 if you want. |
|
I agree with you Adam - requiring code owner approval seems sufficient to me. I'll let @paulofaria make the final call on this one though since he's been the primary maintainer. |
|
Yeah! Let's do it! |
|
Awesome, I've removed the required status checks from GraphQL and aligned the projects throughout GraphQLSwift to have the same main branch protection settings. Thanks guys! |
|
Thank you, Jay! |
As with Graphiti, GraphQL does not have working Linux tests.
This PR resolves this.