Variable and argument null vs undefined #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it was only on variables
|
Hey @paulofaria, since we've removed the ubuntu-16.04 action, could you remove it from the status checks as well? I think you can do so by going to Settings -> Branches -> Require status checks to pass before merging, and uncheck the Ubuntu 16.04 one. |
paulofaria
approved these changes
Oct 3, 2021
|
@NeedleInAJayStack great work! Feel free to merge and tag! |
|
Awesome, thanks @paulofaria! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #87. That PR added support to differentiate between explicitly providing the literal value null and implicitly not providing a value at all in input objects provided in the arguments. This merge request extends that functionality to input objects in variables and non-object arguments.
It also fixes a bug with not pre-validating argument inputs against their type (for example, passing null to a non-null parameter would passed null all the way into the resolver). It also removes force-casts to harden against server-wide fatal errors.