Skip to content

Adds GraphQLRequest type #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

NeedleInAJayStack
Copy link
Member

This type is not used within in this package, but is useful for clients to model the standard execution request information

@paulofaria
Copy link
Member

Do you reckon users will import the whole library just to use this single type? I was working on a client library, some time ago, that would allow users to take a schema from graphiti to create queries. However, I wasn't super happy with the results. Do you have anything in mind on that front? I can share the code I had before, if you're interested.

@NeedleInAJayStack
Copy link
Member Author

Do you reckon users will import the whole library just to use this single type?

While clients could use it, I'd expect that this will be more commonly used by HTTP servers as a Decodable target. It matches the request format of the clients I've used, including Apollo JS, Apollo iOS and graphiql toolkit

Do you have anything in mind on that front?

Sounds interesting! We're currently using other clients and generating their models from the same source as our Graphiti implementation. If it's not a ton of work to share the code, I'd be willing to poke around, but I don't imagine we'll change to a different client library anytime soon.

Thanks for the thoughts!

Copy link
Member

@paulofaria paulofaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NeedleInAJayStack NeedleInAJayStack merged commit 283cc4d into GraphQLSwift:master Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants