-
-
Notifications
You must be signed in to change notification settings - Fork 28
Implement JSON Feed output #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #177 +/- ##
==========================================
+ Coverage 83.96% 84.17% +0.20%
==========================================
Files 10 10
Lines 524 556 +32
Branches 108 118 +10
==========================================
+ Hits 440 468 +28
- Misses 53 56 +3
- Partials 31 32 +1
|
Thanks for your work, it's really cool! Last steps before complete review and merge:
|
@notpushkin any chance to see you fit the missing points in the next days #177 (comment)? Would you accept that I push to your PR? |
@Guts sorry for the wait! If you're up to it, please do finish it up for me – my mind is completely somewhere else right now, so I can't say for sure when I'll be able to do it :-( Again extremely sorry for this half-assed PR, but I hope it helps somebody! |
Signed-off-by: Julien <[email protected]>
Hi @notpushkin, Better late than never, I took the time to achieve your feature. |
Thank you! Sorry for the radio silence, I've had a lot of things going on this year, way over what I can usually handle :') Hope this feature helps other users and somebody will be motivated enough to make it fully compliant! It still should be pretty useful in the meantime. |
No worries! It was already great to come to this PR. Thanks again. I'll make a release in a few days. |
This currently almost passes JSON Feed validator. The few things it complains about are
null
values that should instead be removed from the feed. Apart from that and some code review and more thorough testing I think we're good to go!Closes #165