Skip to content

fix: remove interaction blocker when modal is hidden by extension #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

DDonochVA
Copy link
Contributor

@DDonochVA DDonochVA commented Mar 17, 2025

Summary by CodeRabbit

  • Bug Fixes
    • Adjusted the display behavior of the cookie consent modal to ensure smoother page interactions. If the consent dialog becomes hidden due to external styling effects, full interactivity is automatically restored. Enjoy a more seamless browsing experience with this improvement.

Copy link

coderabbitai bot commented Mar 17, 2025

Walkthrough

A new method onModalShow has been added to cookieConsentConfig in the cookie consent configuration file. This method retrieves the element with ID cc-main and checks if it is hidden. If the element is hidden, it removes the disable--interaction class from the document’s root element. The other methods in the configuration remain unchanged.

Changes

File Change Summary
apps/blog/.../cookie-consent.config.ts Added new method onModalShow to check if the cookie consent modal is hidden and remove the disable--interaction class if needed.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Modal
    participant CookieConsentConfig as Config
    participant DOM

    User->>Modal: Open cookie consent modal
    Modal->>Config: Trigger onModalShow()
    Config->>DOM: Get element with ID "cc-main"
    DOM-->>Config: Return computed style
    alt Element is hidden
        Config->>DOM: Remove "disable--interaction" class from document root
    else Element is visible
        Config-->>DOM: No action taken
    end
Loading

Poem

A bunny hops on lines of code so fine,
"onModalShow" has hopped into the design.
It checks the box where secrets reside,
Removing blocks where interactions hide.
With a twitch of its nose, the path aligns!
🐇✨

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a54fbf7 and f8b94d7.

📒 Files selected for processing (1)
  • apps/blog/src/app/providers/tracking/cookie-consent.config.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Cloudflare Pages
🔇 Additional comments (1)
apps/blog/src/app/providers/tracking/cookie-consent.config.ts (1)

30-38: Excellent solution for handling cookie consent extension conflicts.

The implementation correctly addresses the issue where cookie consent extensions could hide the consent dialog but leave the page interaction blocker in place. By checking if the cookie consent element is hidden and removing the interaction blocker class when needed, this ensures users can still interact with the page.

The code is well-commented with clear explanations and includes a helpful reference to the source library. This is a clean, targeted fix that should improve the user experience when browser extensions modify the cookie consent behavior.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Deploying angular-love-client with  Cloudflare Pages  Cloudflare Pages

Latest commit: f8b94d7
Status: ✅  Deploy successful!
Preview URL: https://3d286eb9.angular-love-client.pages.dev
Branch Preview URL: https://refactor-respect-anti-cookie.angular-love-client.pages.dev

View logs

@DDonochVA DDonochVA merged commit b68d82c into main Mar 17, 2025
2 checks passed
@DDonochVA DDonochVA deleted the refactor/respect-anti-cookie-extensions branch March 17, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant