Nested-objects-encoding #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carries over changes from parse-community#8209 to fix encoding of nested objects, specifically dates.
richardharrington
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
lol this seems like a pretty major oversight for them not to have taken care of in the first place.
Ideally we'd merge this into the 4.3.0-hustle-9.1 branch as well, but these branches are kind of a shit show and we've sort of abandoned the idea of adding to that branch -- which is not working for obscure reasons -- until we get off parse server (or until we have three months till the Mongo upgrade and we haven't made any progress on Parsectomy and we start panicking again).
I was planning to do a short timebox for some possible quick fixes to 4.3.0-hustle-9.1 anyway, so I'll make sure to cherry-pick this over if I do. Or rebase it on 4.3.0-hustle-8, or whatever.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carries over changes from parse-community#8209 to fix encoding of nested objects, specifically dates.