Skip to content

fix: bump node versions to 12,14 #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Conversation

padamstx
Copy link
Member

PR summary

This PR contains changes to the build to build on node versions 12 and 14 (was 10 and 12).
Also, several changes to dependency versions were made to avoid vulnerability alerts.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@padamstx padamstx requested a review from ShyamalaGowri August 17, 2021 14:24
@padamstx padamstx force-pushed the update-node-versions branch from 987e75c to 3d43334 Compare August 17, 2021 14:27
@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #23 (c3bc1f4) into master (6c5cd16) will increase coverage by 100.00%.
The diff coverage is n/a.

❗ Current head c3bc1f4 differs from pull request most recent head 2ecbd5a. Consider uploading reports for the commit 2ecbd5a to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##           master       #23        +/-   ##
=============================================
+ Coverage        0   100.00%   +100.00%     
=============================================
  Files           0         3         +3     
  Lines           0       262       +262     
  Branches        0        36        +36     
=============================================
+ Hits            0       262       +262     
Impacted Files Coverage Δ
ibm-analytics-engine-api/v3.ts 100.00% <0.00%> (ø)
lib/common.ts 100.00% <0.00%> (ø)
ibm-analytics-engine-api/v2.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c5cd16...2ecbd5a. Read the comment docs.

@padamstx padamstx force-pushed the update-node-versions branch from 3d43334 to 2ecbd5a Compare August 17, 2021 14:33
@ShyamalaGowri ShyamalaGowri merged commit a77890a into master Aug 17, 2021
ShyamalaGowri pushed a commit that referenced this pull request Aug 17, 2021
# [1.1.0](v1.0.2...v1.1.0) (2021-08-17)

### Bug Fixes

* bump node versions to 12,14 ([#23](#23)) ([a77890a](a77890a))

### Features

* analytics engine v3 feature changes ([6c5cd16](6c5cd16))
* analytics engine v3 feature changes ([b1cb904](b1cb904))
* analytics engine v3 feature changes ([f7be010](f7be010))
* analytics engine v3 feature changes ([e19751a](e19751a))
* analytics engine v3 feature changes ([39feb3b](39feb3b))
* analytics engine v3 feature changes ([432f5da](432f5da))
* analytics engine v3 feature changes ([a8c4c93](a8c4c93))
ShyamalaGowri pushed a commit that referenced this pull request Aug 17, 2021
# [1.1.0](v1.0.2...v1.1.0) (2021-08-17)

### Bug Fixes

* bump node versions to 12,14 ([#23](#23)) ([a77890a](a77890a))

### Features

* analytics engine v3 feature changes ([6c5cd16](6c5cd16))
* analytics engine v3 feature changes ([b1cb904](b1cb904))
* analytics engine v3 feature changes ([f7be010](f7be010))
* analytics engine v3 feature changes ([e19751a](e19751a))
* analytics engine v3 feature changes ([39feb3b](39feb3b))
* analytics engine v3 feature changes ([432f5da](432f5da))
* analytics engine v3 feature changes ([a8c4c93](a8c4c93))
ShyamalaGowri pushed a commit that referenced this pull request Aug 17, 2021
# [1.1.0](v1.0.2...v1.1.0) (2021-08-17)

### Bug Fixes

* bump node versions to 12,14 ([#23](#23)) ([a77890a](a77890a))

### Features

* analytics engine v3 feature changes ([6c5cd16](6c5cd16))
* analytics engine v3 feature changes ([b1cb904](b1cb904))
* analytics engine v3 feature changes ([f7be010](f7be010))
* analytics engine v3 feature changes ([e19751a](e19751a))
* analytics engine v3 feature changes ([39feb3b](39feb3b))
* analytics engine v3 feature changes ([432f5da](432f5da))
* analytics engine v3 feature changes ([a8c4c93](a8c4c93))
@ShyamalaGowri
Copy link
Contributor

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@subinpc subinpc deleted the update-node-versions branch November 24, 2022 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants