Skip to content

feat: add new sdk method to update instance home credentials #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 23, 2023

Conversation

silpidhua
Copy link
Member

add new sdk method to update instance home credentials.

PR summary

Fixes: <! -- link to issue -->

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

add new sdk method to update instance home credentials.

Signed-off-by: Silpi Dhua <[email protected]>
@silpidhua
Copy link
Member Author

Unit test

npm run test-unit

> [email protected] test-unit
> npm run build && jest test/unit/


> [email protected] build
> tsc && cp package.json dist/

 PASS  test/unit/common.test.js
 PASS  test/unit/ibm-analytics-engine-api.v2.test.js
 PASS  test/unit/ibm-analytics-engine-api.v3.test.js
--------------------------|---------|----------|---------|---------|-------------------
File                      | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
--------------------------|---------|----------|---------|---------|-------------------
All files                 |   99.79 |    93.05 |     100 |   99.79 |                   
 ibm-analytics-engine-api |   99.78 |    93.05 |     100 |   99.78 |                   
  v2.ts                   |   99.41 |    90.62 |     100 |    99.4 | 116               
  v3.ts                   |     100 |       95 |     100 |     100 | 100,1435          
 lib                      |     100 |      100 |     100 |     100 |                   
  common.ts               |     100 |      100 |     100 |     100 |                   
--------------------------|---------|----------|---------|---------|-------------------

Test Suites: 3 passed, 3 total
Tests:       150 passed, 150 total
Snapshots:   0 total
Time:        2.173 s
Ran all test suites matching /test\/unit\//i.

Integration test

npm run test-integration

> [email protected] test-integration
> npm run build && jest test/integration


> [email protected] build
> tsc && cp package.json dist/

 PASS  test/integration/ibm-analytics-engine-api.v3.test.js (21.828 s)
--------------------------|---------|----------|---------|---------|---------------------------------------------------------------------------------------------------------------
File                      | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                                                                                             
--------------------------|---------|----------|---------|---------|---------------------------------------------------------------------------------------------------------------
All files                 |   66.53 |    30.55 |   62.71 |   66.39 |                                                                                                               
 auth                     |     100 |      100 |    12.5 |     100 |                                                                                                               
  index.ts                |     100 |      100 |    12.5 |     100 |                                                                                                               
 ibm-analytics-engine-api |   65.18 |    30.55 |      70 |   65.03 |                                                                                                               
  v2.ts                   |   18.82 |    28.12 |      30 |   18.34 | 58-89,111-135,157-193,215-251,272-315,335-371,391-428,460-499,519-555,576-618,636-672,688-717,738-781         
  v3.ts                   |   91.36 |     32.5 |   96.66 |   91.33 | 55,84,104,132,184,257,328,387,441,498,553,606,666,727,785,840,889,948,1003,1063,1125,1182,1244,1297,1350,1403 
 lib                      |     100 |      100 |     100 |     100 |                                                                                                               
  common.ts               |     100 |      100 |     100 |     100 |                                                                                                               
--------------------------|---------|----------|---------|---------|---------------------------------------------------------------------------------------------------------------

Test Suites: 1 skipped, 1 passed, 1 of 2 total
Tests:       13 skipped, 24 passed, 37 total
Snapshots:   0 total
Time:        22.293 s, estimated 23 s
Ran all test suites matching /test\/integration/i.

update dependency version

Signed-off-by: Silpi Dhua <[email protected]>
.travis.yml Outdated
dist: focal

# Remove this if using external Travis
group: beta
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this?

Silpi Dhua and others added 2 commits March 23, 2023 14:05
fix: remove unused config from travis

Signed-off-by: Silpi Dhua <[email protected]>
fix: remove unused config from travis

Signed-off-by: Silpi Dhua <[email protected]>
@subinpc subinpc merged commit fafb0fa into master Mar 23, 2023
@subinpc subinpc deleted the 3753-update-cos-credentials branch March 23, 2023 09:03
@Surya-Penumatcha
Copy link
Collaborator

🎉 This PR is included in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants