Skip to content

Outdated/Conflicting Documentation #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
I3uckwheat opened this issue Jan 24, 2019 · 7 comments
Closed

Outdated/Conflicting Documentation #22

I3uckwheat opened this issue Jan 24, 2019 · 7 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@I3uckwheat
Copy link

The link for the api reference documentation directs one to: here

This is however inconsistent with the examples listed in the README.md

image

image

@I3uckwheat
Copy link
Author

related to: #10

@kadler
Copy link
Member

kadler commented Jan 24, 2019

The developerWorks docs are out of date. Those docs should be migrated in to this repo and removed from developerWorks (just point a URL back to wherever they land in here).

@abmusse
Copy link
Member

abmusse commented Jan 24, 2019

The developerWorks docs are out of date. Those docs should be migrated in to this repo and removed from developerWorks (just point a URL back to wherever they land in here).

Agreed docs should be migrated from developer works to docs/README.md file

We should reopen #10

@abmusse
Copy link
Member

abmusse commented Jan 24, 2019

Some quick thoughts on what to update from developer works:

  • use 'itoolkit' for requires rather than OPS path
  • use es6 syntax ex: replace var with let and const

@I3uckwheat @kadler

Any other thoughts on what to update from developer works docs?

@ThePrez
Copy link
Member

ThePrez commented Jan 24, 2019

Maybe we should keep the OPS path up for another 3 months until OPS Node.js is completely dead (doc as an alternative, non-recommended path), but make the primary path npm itoolkit (but then we need to circle back in a few months and clean it up, which we should probably do for all of the OPS content anyway)

@I3uckwheat
Copy link
Author

I3uckwheat commented Jan 25, 2019

I am happy to help with updating the documentation.

Some concerns/problems I have run into:

  • npm installation isn't mentioned (I believe it only describes including it from the path)
  • nesting is missing on some of the example XML snippets
  • non-explicit variable names can get confusing. e.g. xt
  • Nothing stating the params put in can also be returned, and the usage of returnParam
  • in the iPgm docs, it doesn't state you have to pass in an empty value to a parameter to get a return value, this has caused much confusion on my part.
  • How to setup and use the itoolkit and not create a new instance each time it's used.

@abmusse abmusse added the good first issue Good for newcomers label Mar 6, 2019
@abmusse abmusse mentioned this issue Jun 24, 2019
@abmusse
Copy link
Member

abmusse commented Aug 19, 2019

Closing after merging PR #58

@abmusse abmusse closed this as completed Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants