Modularize itoolkit.js see issue #20 #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved classes and functions into seperate modules - Added exports to still allow access through itoolkit.js - iConn class moved to iconn.js - iPgm class moved to ipgm.js - iSql class moved to isql.js - iCmd function moved to icmd.js - iSh function moved to ish.js - ProgramCaller moved to programCaller.js - xmlToJson moved to utils.js
- Note: 2 lines have igonered lint rules: 146 and 148
Closed
markdirish
reviewed
Jan 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modularize itoolkit.js see issue #20
Lint
xmlToJsonfunction