general enhancements #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcrespov
approved these changes
Jul 1, 2020
| @@ -13,14 +13,15 @@ | |||
| "docker_base": [ | |||
| "alpine:3.7", | |||
| "alpine:3.8", | |||
| "centos:7", | |||
| "custom:special-image", | |||
There was a problem hiding this comment.
I would be a bit more thatn "special-image" here so we do not end up having "special-image1", "special-image2" :-)
There was a problem hiding this comment.
well there should be only one custom... as basically the aim is to allow to use whatever base in the dockerfile... so if we end up having a special image that becomes very trendy we would add it to the list of available images.
GitHK
approved these changes
Jul 1, 2020
| @@ -13,14 +13,15 @@ | |||
| "docker_base": [ | |||
| "alpine:3.7", | |||
| "alpine:3.8", | |||
| "centos:7", | |||
| @@ -13,14 +13,15 @@ | |||
| "docker_base": [ | |||
| "alpine:3.7", | |||
| "alpine:3.8", | |||
| "centos:7", | |||
| "custom:special-image", | |||
There was a problem hiding this comment.
it is only to ease the creation of custom images (such as based on images not available in this list, e.g. nvidia-stuff or matlab...)
There was a problem hiding this comment.
Would custom:image-template be a better name?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
brings changes created by @mguidon and fixes found during @KZzizzle service creations
closes #29
closes #31
Related issue number
Checklist