Skip to content

WIP: Fix/integration #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 52 commits into from
Apr 3, 2019
Merged

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Feb 11, 2019

What do these changes do?

  • Fixes while integrating cc in osparc-simcore development workflow
  • list features in CHANGELOG.md both of baked service and template
  • add template tests for docker operations

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you design a new module, add your user to .github/CODEOWNERS

@ghost
Copy link

ghost commented Feb 11, 2019

DeepCode analyzed this pull request.
There are no new issues.

@pcrespov pcrespov requested a review from sanderegg as a code owner February 15, 2019 10:08
@ghost ghost assigned sanderegg Mar 1, 2019
@ghost ghost added the review label Mar 1, 2019
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty cool stuff.
these are my first ideas. I will try it ASAP.

@sanderegg
Copy link
Member

sanderegg commented Mar 5, 2019

Just tried the cookie cutter and have some questions:

  • after make run I received an output folder where an empty packages folder is visible. Why that?
  • in the generated Dockerfile these TODOs are visible:
#  TODO: consider installing tooling in a separate virtualenv?
#  TODO: really necesary???

you now took the decision to not use a virtualenv inside the docker container, didn't you?

  • wondering if the generated docker-compose file should include a config entry or not?
  • what is the way of building the docker of the generated stub? I tried the following:
make venv
source .venv/bin/activate
make install
make requirements # fails because pip-compile is missing
docker build services/test # fails as requirements files are missing

Very nice stuff!

@ghost ghost assigned pcrespov Mar 5, 2019
@pcrespov pcrespov changed the title Fix/integration WIP: Fix/integration Mar 5, 2019
@pcrespov pcrespov merged commit 9d65eeb into ITISFoundation:master Apr 3, 2019
@ghost ghost removed the review label Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants