Connect traefiks to opentelemetry #1041
Conversation
…oundation#979) * Introduce longhorn chart * Further longhorn configuration * Longhorn: further settings configuration * Fix longhorn configuration bugs Extra: introduce longhorn pv vales for portainer * Add comment for deletion longhorn * Further longhorn configuration * Add README.md for Longhorn wit FAQ * Update Longhorn readme * Update readme * Futher LH configuration * Update LH's Readme * Update Longhorn Readme * Improve LH's Readme * LH: Reduce reserved default disk space to 5% Since we use a dedicated disk for LH, we can go ahead with 5% * Use values to set Longhorn storage class * Update LH's Readme * LH Readme: add requirements reference * PR Review: bring back portainer s3 pv * LH: decrease portinaer volume size
I guess yes, traefik --> opentelemetry-collector --> tempo/jaeger would be on there. I can add a flag to turn it on/off via env-var. Would that be better? |
mrnicegyu11
changed the title
| - "--tracing.otlp=true" | ||
| - "--tracing.otlp.http=true" | ||
| - "--tracing.serviceName=simcore-traefik" | ||
| - "--tracing.otlp.http.endpoint=http://otel-collector:4318/v1/traces" |
There was a problem hiding this comment.
Shall we use env variables to avoid hardcoding host and port?
There was a problem hiding this comment.
configuration refactoring for this in mrnicegyu11#1, please review :--) thx
There was a problem hiding this comment.
This looks good to me, but maybe make clear in the description of the PR exactly what this PR adds. Do I get it correctly, that it "instruments" traefik. So that e.g. if we look into the logs of traefik we can see traceids of requests? Or is this simply to "add" a trace id to a request when it arrives?
What do these changes do?
Connect traefiks to opentelemetry
Tested this successfully on osparc-master-zmt-click
Related issue/s
Related PR/s
Checklist