Skip to content

Fix pylint bug #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 28, 2020
Merged

Fix pylint bug #48

merged 3 commits into from
Apr 28, 2020

Conversation

sanderegg
Copy link
Member

What do these changes do?

  • fixes issues in other services due to updated pylint 2.5.0 that brings a new bug
  • fixes warnings by setting a pylint.ini

Related issue number

Checklist

  • I think the code is well written
  • I updated the table of contents (make toc)
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Runs in the swarm
  • If you design a new module, add your user to .github/CODEOWNERS

@sanderegg sanderegg added this to the Zhong Zi milestone Apr 28, 2020
@sanderegg sanderegg self-assigned this Apr 28, 2020
pcrespov
pcrespov approved these changes Apr 28, 2020
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

KZzizzle
KZzizzle approved these changes Apr 28, 2020
View reviewed changes
Copy link
Collaborator

@KZzizzle KZzizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! That version of pylint is my favorite too

@sanderegg sanderegg merged commit da6501a into ITISFoundation:master Apr 28, 2020
@sanderegg sanderegg deleted the fix_pylint_bug branch April 28, 2020 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KZzizzle KZzizzle KZzizzle approved these changes

@pcrespov pcrespov pcrespov approved these changes

@odeimaiz odeimaiz Awaiting requested review from odeimaiz odeimaiz is a code owner

Assignees

@sanderegg sanderegg

Labels
None yet
Projects
None yet
Milestone
Zhong Zi
Development

Successfully merging this pull request may close these issues.
3 participants
@sanderegg @KZzizzle @pcrespov