Skip to content

Commit 13e60dd

Browse files
authored
Fixes boot failure in devel mode (#1477)
Reference to common requirements.txt cannot be reached in devel containers because the file is not mounted. The most cost effective solution is to copy&past common requirements (they do not change much) since COPYing the file in the Dockefile is more disruptive
1 parent 71ea6d2 commit 13e60dd

File tree

7 files changed

+54
-8
lines changed

7 files changed

+54
-8
lines changed

requirements.txt

+4
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@
99
# NOTE: None of thes tools are part of the automatic testing
1010
# NOTE: pylint is already included as test dependency
1111

12+
# FIXME: this file cannot be referenced by services/{}/requirements/dev.txt
13+
# because it is NOT mounted in devel container. Therefore the question is
14+
# how to sync??
15+
1216
# formatter
1317
black
1418
# dependency manager

services/api-gateway/requirements/dev.txt

+8-1
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,12 @@
1313
-e .
1414

1515
# basic dev tools
16-
-r ../../../requirements.txt
1716
watchdog[watchmedo]
17+
18+
## NOTE: Copied from ../../../requirements.txt to avoid mounting
19+
# basedir in docker during devel-mode.
20+
# TODO: Better solution needed!
21+
black
22+
pip-tools
23+
bump2version
24+
rope

services/catalog/requirements/dev.txt

+10-3
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,6 @@
66
# pip install -r requirements/dev.txt
77
#
88

9-
# basic dev tools
10-
-r ../../../requirements.txt
11-
129
# installs base + tests requirements
1310
-r _test.txt
1411

@@ -17,3 +14,13 @@
1714

1815
# installs current package
1916
-e .
17+
18+
# basic dev tools
19+
20+
## NOTE: Copied from ../../../requirements.txt to avoid mounting
21+
# basedir in docker during devel-mode.
22+
# TODO: Better solution needed!
23+
black
24+
pip-tools
25+
bump2version
26+
rope

services/director/requirements/dev.txt

+8-1
Original file line numberDiff line numberDiff line change
@@ -18,5 +18,12 @@
1818
-e .
1919

2020
# basic dev tools
21-
-r ../../../requirements.txt
2221
watchdog[watchmedo]
22+
23+
## NOTE: Copied from ../../../requirements.txt to avoid mounting
24+
# basedir in docker during devel-mode.
25+
# TODO: Better solution needed!
26+
black
27+
pip-tools
28+
bump2version
29+
rope

services/sidecar/requirements/dev.txt

+8-1
Original file line numberDiff line numberDiff line change
@@ -21,5 +21,12 @@
2121
-e .
2222

2323
# basic dev tools
24-
-r ../../../requirements.txt
2524
watchdog[watchmedo]
25+
26+
## NOTE: Copied from ../../../requirements.txt to avoid mounting
27+
# basedir in docker during devel-mode.
28+
# TODO: Better solution needed!
29+
black
30+
pip-tools
31+
bump2version
32+
rope

services/storage/requirements/dev.txt

+8-1
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,12 @@
1919
-e .
2020

2121
# basic dev tools
22-
-r ../../../requirements.txt
2322
watchdog[watchmedo]
23+
24+
## NOTE: Copied from ../../../requirements.txt to avoid mounting
25+
# basedir in docker during devel-mode.
26+
# TODO: Better solution needed!
27+
black
28+
pip-tools
29+
bump2version
30+
rope

services/web/server/requirements/dev.txt

+8-1
Original file line numberDiff line numberDiff line change
@@ -20,5 +20,12 @@
2020
-e .
2121

2222
# basic dev tools
23-
-r ../../../../requirements.txt
2423
watchdog[watchmedo]
24+
25+
## NOTE: Copied from ../../../requirements.txt to avoid mounting
26+
# basedir in docker during devel-mode.
27+
# TODO: Better solution needed!
28+
black
29+
pip-tools
30+
bump2version
31+
rope

0 commit comments

Comments
 (0)