Skip to content

Fixes boot failure in devel mode #1477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2020

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Apr 30, 2020

Reference to common requirements.txt cannot be reached in devel containers
because the file is not mounted.
The most cost effective solution is to copy&past common requirements (they
do not change much) since COPYing the file in the Dockefile is more
disruptive

Checklist

  • Runs in the swarm in devel mode

Reference to common requirements.txt cannot be reached in devel containers
because the file is not mounted.
The most cost effective solution is to copy&past common requirements (they
do not change much) since COPYing the file in the Dockefile is more
disruptive
@pcrespov pcrespov self-assigned this Apr 30, 2020
@pcrespov pcrespov added this to the Zhong Zi milestone Apr 30, 2020
@codecov
Copy link

codecov bot commented Apr 30, 2020

Codecov Report

Merging #1477 into master will decrease coverage by 13.23%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1477       +/-   ##
===========================================
- Coverage   71.47%   58.23%   -13.24%     
===========================================
  Files         244      164       -80     
  Lines        9706     6407     -3299     
  Branches     1060      664      -396     
===========================================
- Hits         6937     3731     -3206     
- Misses       2464     2512       +48     
+ Partials      305      164      -141     
Flag Coverage Δ
#integrationtests 56.70% <ø> (-1.94%) ⬇️
#unittests 70.57% <ø> (+7.31%) ⬆️
Impacted Files Coverage Δ
...erver/src/simcore_service_webserver/rest_models.py 0.00% <0.00%> (-91.18%) ⬇️
...er/src/simcore_service_webserver/storage_routes.py 20.00% <0.00%> (-80.00%) ⬇️
...er/src/simcore_service_webserver/users_handlers.py 29.03% <0.00%> (-70.97%) ⬇️
...er/src/simcore_service_webserver/login/handlers.py 22.39% <0.00%> (-65.11%) ⬇️
...er/src/simcore_service_webserver/studies_access.py 24.46% <0.00%> (-63.83%) ⬇️
...src/simcore_service_webserver/activity/handlers.py 26.08% <0.00%> (-63.77%) ⬇️
...mcore_service_webserver/projects/projects_utils.py 14.81% <0.00%> (-62.97%) ⬇️
...imcore_service_webserver/diagnostics_monitoring.py 29.50% <0.00%> (-62.30%) ⬇️
...mcore_service_webserver/login/api_keys_handlers.py 36.76% <0.00%> (-55.89%) ⬇️
...rc/simcore_service_webserver/diagnostics_plugin.py 45.16% <0.00%> (-54.84%) ⬇️
... and 127 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71ea6d2...9c7065d. Read the comment docs.

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works!

@pcrespov pcrespov merged commit 13e60dd into ITISFoundation:master Apr 30, 2020
@pcrespov pcrespov deleted the fix/booting-devel branch April 30, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants