Skip to content

Improvements on tests/e2e setup #1367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pcrespov opened this issue Mar 13, 2020 · 3 comments
Closed

Improvements on tests/e2e setup #1367

pcrespov opened this issue Mar 13, 2020 · 3 comments
Assignees
Labels
t:maintenance Some planned maintenance work

Comments

@pcrespov
Copy link
Member

pcrespov commented Mar 13, 2020

After using tests/e2e, I would like to propose some improvements:

Makefile MUST work locally

make TARGET must work locally, not only for the e2e.bash. Now, it needs of some config provided in the ci/*/system-testing/e2e.bash.
A developer shall be able to run tests locally in a similar manner throughout all modules and without any hack. Other services/packages follow the same workflow

make devenv
source .venv/bin/activate

cd mymodule
make install-dev # or any flavor or make install
make tests

Tests MUST NOT change host config

When running tests locally, it MUST NOT globaly install anything. This changes the installation of the host computer!
If it cannot be installed locally (e.g. virtualenv, pyenv, node_modules, etc) then try using docker

For instance:

  • sudo apt install -y postgresql-client in e2e.bash installs psql client! Can this be done within a docker??
  • 127.0.0.1==registry: integrate setup_env_insecure_registry.bash in Makefile, otherwise it does NOT work. If this case is unavoidable, make sure to undo the changes after recipe is finished. in PR is1594 fix and re-activate e2e testing #1620

Avoid duplication [PR #1620]

Since we have a script per CI system, i.e.

  • ci/github/system-testing/e2e.bash
  • ci/travis/system-testing/e2e.bash
    try moving relevant/common functionliaty in the local Makefile
@pcrespov pcrespov added the t:maintenance Some planned maintenance work label Mar 13, 2020
pcrespov added a commit that referenced this issue Jul 20, 2020
Solves #1594 and part of #1367

- e2e runs in host ( partially implements #1367). installs/uninstall insecure registry (see e2e.bash )
- e2e flow is reviewed and updated
- e2e is reactivated in github actions and removed from travis. Fixes bugs in postgres migration scripts related to unhandled exceptions
@sanderegg
Copy link
Member

@pcrespov : is this completed now?

@pcrespov
Copy link
Member Author

@pcrespov : is this completed now?

@sanderegg I crossed what it is implemented

@sanderegg
Copy link
Member

@pcrespov can we close this now? I think what is not crossed is not valid anymore

@pcrespov pcrespov closed this as completed Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

No branches or pull requests

3 participants