You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After using tests/e2e, I would like to propose some improvements:
Makefile MUST work locally
make TARGET must work locally, not only for the e2e.bash. Now, it needs of some config provided in the ci/*/system-testing/e2e.bash.
A developer shall be able to run tests locally in a similar manner throughout all modules and without any hack. Other services/packages follow the same workflow
make devenv
source .venv/bin/activate
cd mymodule
make install-dev # or any flavor or make install
make tests
Tests MUST NOT change host config
When running tests locally, it MUST NOT globaly install anything. This changes the installation of the host computer!
If it cannot be installed locally (e.g. virtualenv, pyenv, node_modules, etc) then try using docker
For instance:
sudo apt install -y postgresql-client in e2e.bash installs psql client! Can this be done within a docker??
127.0.0.1==registry: integrate setup_env_insecure_registry.bash in Makefile, otherwise it does NOT work. If this case is unavoidable, make sure to undo the changes after recipe is finished. in PR is1594 fix and re-activate e2e testing #1620
Solves #1594 and part of #1367
- e2e runs in host ( partially implements #1367). installs/uninstall insecure registry (see e2e.bash )
- e2e flow is reviewed and updated
- e2e is reactivated in github actions and removed from travis. Fixes bugs in postgres migration scripts related to unhandled exceptions
After using tests/e2e, I would like to propose some improvements:
Makefile MUST work locally
make TARGET
must work locally, not only for thee2e.bash
. Now, it needs of some config provided in theci/*/system-testing/e2e.bash
.A developer shall be able to run tests locally in a similar manner throughout all modules and without any hack. Other services/packages follow the same workflow
Tests MUST NOT change host config
When running tests locally, it MUST NOT globaly install anything. This changes the installation of the host computer!
If it cannot be installed locally (e.g. virtualenv, pyenv, node_modules, etc) then try using docker
For instance:
sudo apt install -y postgresql-client
ine2e.bash
installs psql client! Can this be done within a docker??in PR is1594 fix and re-activate e2e testing #1620127.0.0.1==registry
: integrate setup_env_insecure_registry.bash in Makefile, otherwise it does NOT work. If this case is unavoidable, make sure to undo the changes after recipe is finished.Avoid duplication[PR #1620]Since we have a script per CI system, i.e.
try moving relevant/common functionliaty in the local Makefile
The text was updated successfully, but these errors were encountered: