Skip to content

From python-socketio >=4.4 client does not raise when our socket server refuses connection #1445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pcrespov opened this issue Apr 8, 2020 · 2 comments
Assignees
Labels
a:webserver issue related to the webserver service bug buggy, it does not work as expected t:maintenance Some planned maintenance work

Comments

@pcrespov
Copy link
Member

pcrespov commented Apr 8, 2020

python-socketio release >=4.4 fail this test

pytest --ff services/web/server/tests/unit/with_dbs/test_resource_manager.py::test_anonymous_websocket_connection

the test checks that when socket connection is refused (non-authorized) the server handler services/web/server/src/simcore_service_webserver/socketio/handlers.py raises an exception that randomly reaches the client

See test failure https://travis-ci.com/github/ITISFoundation/osparc-simcore/jobs/317121817#L1092

These were upgraded dependencies
image.png

then, we downgraded python-socketio and increased until it failed

See PR #1444 to understand all process

@pcrespov pcrespov added the t:maintenance Some planned maintenance work label Apr 8, 2020
@pcrespov pcrespov added a:webserver issue related to the webserver service bug buggy, it does not work as expected labels Apr 8, 2020
@pcrespov
Copy link
Member Author

pcrespov commented Apr 8, 2020

with 4.3, the exception message is also different
image

@pcrespov
Copy link
Member Author

pcrespov commented Apr 8, 2020

@sanderegg Another test in test_resource_manager is failing and now is not as random as in the past:

see the redis warning (BTW why closing is logged as warning? was it unexpected?)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service bug buggy, it does not work as expected t:maintenance Some planned maintenance work
Projects
None yet
Development

No branches or pull requests

3 participants