[maintenance] Upgrades webserver's requirements #1444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1444 +/- ##
=======================================
Coverage 50.64% 50.64%
=======================================
Files 68 68
Lines 2079 2079
Branches 210 210
=======================================
Hits 1053 1053
Misses 970 970
Partials 56 56
Continue to review full report at Codecov.
|
This was referenced Apr 7, 2020
pcrespov
changed the title
pcrespov
force-pushed
the
maintenance/reqs
branch
from
7202fbf to
1356025
Compare
pcrespov
changed the title
sanderegg
approved these changes
Apr 9, 2020
This was referenced Apr 14, 2020
|
@sanderegg could you please look at the tests failing due to socketio and give some feedback? THX! |
5 tasks
cryptograpy and test-sugar
- fixes f-string-without-interpolation
This was referenced Apr 28, 2020
This was referenced Apr 28, 2020
Conflicts: requirements.txt services/api-gateway/requirements/dev.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Upgrade strategy starts by upgrading all package requirements to their latest versions and testing them. This establishes constraints on base input requirements that are included in the webserver service's input requirements. These requirements are compiled to get latest upgrades. If fails, constraints are added either in the input requirements of the service or in one of more of the packages, depending on the nature of the failure.
Specifically, these are the changes:
Review and upgrade test requirements of packages:
Upgrades webserver's dependencies:
Makefile cleanup
make cleanunder different conditionsmake clean-psto remove docker containersmake reqsin webserver now include dependencies to_base.inpackagesFIXES: exec boot of webserver and director to grant graceful shutdown
Related issue number
Part of #1412 to upgrade python
How to test
make devenv cd services/web/server make install-dev testsChecklist
make openapi-specs,git commit ...and thenmake version-*)