Skip to content

Service submission email has wrong subject #1567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ignapas opened this issue Jun 18, 2020 · 2 comments · Fixed by #1608
Closed

Service submission email has wrong subject #1567

ignapas opened this issue Jun 18, 2020 · 2 comments · Fixed by #1608
Assignees
Labels
a:webserver issue related to the webserver service bug buggy, it does not work as expected

Comments

@ignapas
Copy link
Contributor

ignapas commented Jun 18, 2020

Someone submitted a new service candidate and the mail's subject shows the prefix TEST: , which should only be used in testing environments.

@ignapas ignapas added a:webserver issue related to the webserver service bug buggy, it does not work as expected labels Jun 18, 2020
@ignapas ignapas self-assigned this Jun 18, 2020
@KZzizzle
Copy link
Contributor

KZzizzle commented Jul 7, 2020

Could I add two feature requests if you are working on the submission form here:

  • Email attaches .json file in addition to nicely formatted email (so I can automatically parse)
  • Addition of "units" field for each input and output, though the field can be optional (for your input validation)

Let me know if I should create separate issues for these features

@ignapas
Copy link
Contributor Author

ignapas commented Jul 9, 2020

Could I add two feature requests if you are working on the submission form here:

  • Email attaches .json file in addition to nicely formatted email (so I can automatically parse)
  • Addition of "units" field for each input and output, though the field can be optional (for your input validation)

Let me know if I should create separate issues for these features

noted. I will add this in my next PR... although I remember I already did the json file attachment part... Idk where it ended up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants