Skip to content

Some enhancements and bug fixes #1608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jul 14, 2020
Merged

Some enhancements and bug fixes #1608

merged 18 commits into from
Jul 14, 2020

Conversation

ignapas
Copy link
Contributor

@ignapas ignapas commented Jul 7, 2020 •
edited
Loading

What do these changes do?

  • Fixes wrong subject in service submission email
  • Added osparc.window.Window component with clickAwayClose function.
  • Added faded modal overlay.

Related issue number

closes #1567 #1609 #1607

How to test

  • Service submission email has right subject
  • Check window styles, modal overlays and click away close
  • Can edit study info from dashboard
  • Dashboard studies update after name change inside study

Screenshot

Click away to close and modal overlay

In PR, click away is only activated for permissions window.
clickaway

Checklist

  • Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@ignapas ignapas changed the title Some enhancements and bug fixes WIP Some enhancements and bug fixes Jul 7, 2020
@ignapas ignapas changed the title WIP Some enhancements and bug fixes WIP: Some enhancements and bug fixes Jul 7, 2020
@codecov
Copy link

codecov bot commented Jul 7, 2020 •
edited
Loading

Codecov Report

Merging #1608 into master will decrease coverage by 0.5%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1608     +/-   ##
========================================
- Coverage    73.7%   73.1%   -0.6%     
========================================
  Files         278     278             
  Lines       10884   10884             
  Branches     1178    1178             
========================================
- Hits         8029    7965     -64     
- Misses       2514    2577     +63     
- Partials      341     342      +1
Flag Coverage Δ
#integrationtests 56.7% <ø> (ø)
#unittests 68.7% <ø> (+1.2%) ⬆️
Impacted Files Coverage Δ
.../simcore_service_webserver/publication_handlers.py 29.7% <ø> (ø)
...ar/src/simcore_service_sidecar/celery_log_setup.py 0.0% <0.0%> (-69.3%) ⬇️
...src/simcore_service_sidecar/celery_configurator.py 0.0% <0.0%> (-55.4%) ⬇️
...vices/sidecar/src/simcore_service_sidecar/utils.py 69.4% <0.0%> (-23.8%) ⬇️
.../sidecar/src/simcore_service_sidecar/log_parser.py 79.6% <0.0%> (-11.9%) ⬇️
.../director/src/simcore_service_director/producer.py 63.5% <0.0%> (+0.4%) ⬆️

@ignapas ignapas changed the title WIP: Some enhancements and bug fixes Some enhancements and bug fixes Jul 10, 2020
@ignapas
Copy link
Contributor Author

ignapas commented Jul 13, 2020

@GitHK @Surfict There might be a problem here with the file cache in the actions... Frontend testing is failing although I already pushed the code to solve them

@GitHK
Copy link
Contributor

GitHK commented Jul 13, 2020 •
edited by ignapas
Loading

@GitHK @Surfict There might be a problem here with the file cache in the actions... Frontend testing is failing although I already pushed the code to solve them

From what I see is eslint is complaining about something. Caching should not be the issue.

@ignapas
Copy link
Contributor Author

ignapas commented Jul 13, 2020

@GitHK @Surfict There might be a problem here with the file cache in the actions... Frontend testing is failing although I already pushed the code to solve them

From what I see is eslint is complaining about something. Caching should not be the issue.

I know but those are corrected!

@GitHK
Copy link
Contributor

GitHK commented Jul 13, 2020

@GitHK @Surfict There might be a problem here with the file cache in the actions... Frontend testing is failing although I already pushed the code to solve them

From what I see is eslint is complaining about something. Caching should not be the issue.

I know but those are corrected!

Would you mind adding a line where the CI dumps the file before sling runs? You could simply do it as a cat command.

odeimaiz
odeimaiz approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Schön!

GitHK
GitHK approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz added this to the Xie-Xie milestone Jul 14, 2020
@ignapas ignapas merged commit 18fa7aa into ITISFoundation:master Jul 14, 2020
@odeimaiz odeimaiz mentioned this pull request Aug 4, 2020
Merged
odeimaiz added a commit that referenced this pull request Aug 4, 2020
@odeimaiz
FREEZE_XieXie (#1669)
5ec7ff1 
- UI/UX improvements (#1657)
- Bump yarl from 1.4.2 to 1.5.1 in /packages/postgres-database (#1665)
- Bump ujson from 3.0.0 to 3.1.0 in /packages/service-library (#1664)
- Bump pytest-docker from 0.7.2 to 0.8.0 in /packages/service-library (#1647)
- Improving storage performance (#1659)
- Bump aiozipkin from 0.6.0 to 0.7.0 in /packages/service-library (#1642)
- Theming (#1656)
- Platform stability:  (#1645)
- is1594 fix and re-activate e2e testing (#1620)
- 2 bugs fixed + Some improvements (#1634)
- Fixes default (#1640)
- Bump lodash from 4.17.15 to 4.17.19 (#1639)
- Is1585/cleanup storage (#1586)
- Fixes on publish studies handling (#1632)
- Some enhancements and bug fixes (#1608)
- Improve e2e  (#1631)
- filter studies by name before deleting them (#1629)
- Maintenance/upgrades test tools (#1628)
- Bugfix/concurent opening projects (#1598)
- Bugfix/allow reading groups anonymous user (#1615)
- Bump docker from 4.2.1 to 4.2.2 in /packages/postgres-database (#1605)
- fix testing if node has gpu support (#1604)
- [bugfix] Invalidate cache before starting a study (#1602)
- Feature/fix e2e 2 (#1600)
- fix deploy not needing e2e testing since it is disabled
- reduce cardinality of metrics (#1593)
- Excudes e2e stage from include until fixed (#1595)
- Shared project concurrency (frontend) (#1591)
- Homogenize studies and services (#1569)
- [feature] UI Fine grained access - project locking and notification
- Bugfix/apiserver does not need sslheaders (#1564)
- Cleanup catalog service (#1582)
- Maintenance/cleanup api server (#1578)
- Adds support for GPU scheduling of computational services (#1553)
- Maintenance/upgrades and tooling (#1546)
- Is1570/study fails 500 (#1572)
- Bump faker from 4.1.0 to 4.1.1 in /packages/postgres-database (#1573)
- maintenance fix codecov reports (#1568)
- Manage groups, Share studies (#1512)
- Is/add notebook migration script (#1565)
- Is1269/api-server upgrade (#1475)
- added simcore_webserver_service in pytest simcore package (#1563)
- add traefik endpoint to api-gateway (#1555)
@sanderegg sanderegg mentioned this pull request Aug 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov pcrespov approved these changes

@odeimaiz odeimaiz odeimaiz approved these changes

@Surfict Surfict Awaiting requested review from Surfict

Assignees

@ignapas ignapas

Labels
None yet
Projects
None yet
Milestone
Xie-Xie
Development

Successfully merging this pull request may close these issues.

Service submission email has wrong subject
4 participants
@ignapas @GitHK @pcrespov @odeimaiz