Skip to content

Cardiac Tissue model (myocytes) from Colleen Clancy (C++ code) #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
6 tasks done
mguidon opened this issue Jan 23, 2018 · 4 comments
Closed
6 tasks done

Cardiac Tissue model (myocytes) from Colleen Clancy (C++ code) #3

mguidon opened this issue Jan 23, 2018 · 4 comments
Labels
PO issue Created by Product owners [PLEASE use osparc-issue repo]

Comments

@mguidon
Copy link
Member

mguidon commented Jan 23, 2018

User story

As a user I want to create a pipeline consisting of the cardiac tissue model from Colleen Clancy and a post-processing service that reproduces the plots in the official MVP use case. I am able to edit all necessary input settings directly in the frontend. Optionally, I would like to have the option to choose a compiler and compiler flags in case I want to build the kernel first.

Definition of Done

  • The model is available in the list of services
  • The required pipeline can be created
  • The code is containerized as binary and as code only with compilation performed on the fly
  • For the second part of the pipeline, either python or octave/matlab will be used
  • check if there is a need/possibility to have settings (property window)
  • the results of the python postpro script should be mapped as time series to the outputs, such that they can be visualized with the 2d plot service (item was modified)

Use case
There is documentation/code/Kepler example for this case in filesrv. In addition, the full workflow is available on MaG's VM.

@mguidon
Copy link
Member Author

mguidon commented Feb 2, 2018

for the future: https://mybinder.org/

sanderegg referenced this issue in sanderegg/osparc-simcore May 11, 2018
WIP: Updated doc and several fixes on container configurations. WARNING: system still not working!
@esraneufeld
Copy link
Member

the option to first compile the code is lower priority than the rest of this case.

@sanderegg
Copy link
Member

sanderegg commented Jun 6, 2018

(- [ ] automatic deployment of master (IT) (#99 ))
(- [ ] web access to the frontend (#98 ))

@sanderegg sanderegg added this to the Gemenon milestone Jun 6, 2018
sanderegg added a commit that referenced this issue Jun 22, 2018
added notebooks for #3 use case for displaying 2D graphs
enhanced simcore-sdk/nodeports package to connect to S3, postgres, download from S3 and compatible with the docker swarm.
@sanderegg sanderegg added backlog and removed backlog labels Jun 29, 2018
@sanderegg sanderegg modified the milestones: Gemenon, Leonis Jun 29, 2018
@pcrespov pcrespov modified the milestones: Leonis, Libra Aug 15, 2018
@pcrespov pcrespov removed the review label Sep 11, 2018
@pcrespov pcrespov reopened this Sep 11, 2018
@pcrespov pcrespov removed this from the Libra milestone Sep 11, 2018
@drniiken
Copy link
Member

For the very moment, we are happy with the Jupyter based 2D plot visualization.

@mguidon mguidon added PO issue Created by Product owners [PLEASE use osparc-issue repo] review and removed Area: compend labels Jan 10, 2019
@ghost ghost removed the in progress label Apr 10, 2019
GitHK added a commit that referenced this issue Apr 26, 2021
* moved service-sidecar contents

* added task to run unittests

* added unittests bash commands

* added command to run unittests locally

* added entry to build dynamic-sidecar

* coverage and deploy now await for dynamic-sidecar

* renamed service-sidecar to dynamic-sidecar

* renaming missing folder

* renaming missing fodler part 2

* updating makefile

* updating tox

* removing tox

* added ci codestyle check before tests run

* removed unsued targets

* fixed error message

* added missing test

* added codeoowner entry

* moved mocked fucntions to the same module

* renamed module

* updating log warning messages for mocked calls

* added some help

* clrifying command usage

* using verbatim arguments

* fixed typo

* renived tests

* renaming ServiceSidecarSettings to DynamicSidecarSettings

* updated name in changelog

* fixed ptsv entrypoint

* fixed healt endpoint to fail when status is not healthy

* fixed route and test

* mappign docs on the same route as other services

* added api prefix for interested routes

* codestyle

* container api routes refactored

* renamed storage to shared_store

* refacted shared_store to use Pydantic models

* missed a rename

* added makefile entry to generate openapi spec

* adding correct mypy file

* mypy suggestions

* added openapi.json for the service

* codestyle also updates openapi.json

* added common scripts to enforce codestyles in development and CI

* imported statuses from fastapi/starlette definitions

* updated docstring

* fixed imports, now importing from starlette

* moved mark.asyncio

* moved act into bash script

* added act entry to common.Makefile

* added entry for development of dunamic-sidecar

* added test to check the spec has was updated

* added missing fixture

* updated readme

* removed unused APIs and renamed existing

* added docker-compose config validation

* moved settings and shared state to dependencies

* minor improvments

* updated requirements

* added missing service to SERVICES_LIST

* Some suggestions (#3) from sanderegg

* naming

* consistency

* shellcheck

* proposed refactoring on dynamic sidecar (#4)

* removes responses and raise exceptions for errors

* Minor typo

* Should include standard entrypoint

* refactor health and added dependencies

* minor

* fixes

* fixed codestyle

* fixed typos

* fixed compose API entrypoints and tests

* refactored api structure and endpoints

* extended utils

* adapted new tests

* updated API spec

* moving routes under the same module

* moved tests and updated openapi.json

* updated script entryoint name

* renamed endpoint

* refactor

* refactor error raising and staus code for resource not found

* regenerated openapi.json spec

* codestyle :\

* merged /containers and /containers:inspect

* wrong default value

* test clenup

* updated openapi.json

* clarify comment

* removed unused API

* removed command timeout when posting to createing services via docker-compose

* removing unecessary timeouts

* forgot to implement it

* after the request is accepted the list of container names is returned

* removed flag which is no longer used

* fixed tests

* moved ApplicationHealth and codestyle fixes

* added test to check it can run twice the same compos spec with different project-name

* fixed codestyle

* setting default and documentation to argument

* updated oepnapi.json

* fixed test to properly work based on workspace

* refactoring application models structure

* rending applicaiton strucutre similar to other fastapi services

* replacing with response.json()

* applied codestyle

* comitting new updated dependencies

* refactoring error codes

* clened up exception throwing

* restored error emssage

Co-authored-by: Andrei Neagu <[email protected]>
Co-authored-by: Sylvain <[email protected]>
Co-authored-by: Pedro Crespo-Valero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PO issue Created by Product owners [PLEASE use osparc-issue repo]
Projects
None yet
Development

No branches or pull requests

8 participants