Skip to content

Fix director service discovery #1538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Jun 2, 2020

What do these changes do?

Fixes an issue where the director was not completely filtering the services by the swarm_stack_name label

Related issue number

How to test

Checklist

  • Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@GitHK GitHK added the bug buggy, it does not work as expected label Jun 2, 2020
@GitHK GitHK self-assigned this Jun 2, 2020
@GitHK GitHK changed the title WIP: Fix servces running services discovery WIP: Fix director service discovery Jun 2, 2020
@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #1538 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1538   +/-   ##
=======================================
  Coverage   71.33%   71.33%           
=======================================
  Files         249      249           
  Lines       10015    10015           
  Branches     1106     1106           
=======================================
  Hits         7144     7144           
  Misses       2553     2553           
  Partials      318      318           
Flag Coverage Δ
#integrationtests 57.71% <ø> (ø)
#unittests 63.29% <100.00%> (ø)
Impacted Files Coverage Δ
.../director/src/simcore_service_director/producer.py 65.32% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83b3a2b...935ead7. Read the comment docs.

@GitHK GitHK changed the title WIP: Fix director service discovery Fix director service discovery Jun 3, 2020
@GitHK GitHK requested review from sanderegg and pcrespov June 3, 2020 05:41
@GitHK GitHK marked this pull request as ready for review June 3, 2020 05:41
@GitHK GitHK requested a review from sanderegg June 3, 2020 09:06
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GitHK GitHK merged commit 403df86 into ITISFoundation:master Jun 4, 2020
@GitHK GitHK mentioned this pull request Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants