Skip to content

Bugfix/comp services see all inputs #1734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Aug 24, 2020

What do these changes do?

  • sidecar now bind mount only a subfolder of the respective named volumes (input,output,log) by inspecting the said volumes to get their mountpoints on the hosts (NOTE: this might break running comp services locally on a Windows machine with WSL1)
  • Therefore the computational services that change the user/groups of each files should go faster since they won't have access to anything else than their defined subfolder

Bonus:

Related issue number

fixes #1723

How to test

Checklist

  • Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@sanderegg sanderegg added this to the Da Jia milestone Aug 24, 2020
@sanderegg sanderegg self-assigned this Aug 24, 2020
@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #1734 into master will decrease coverage by 0.0%.
The diff coverage is 78.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1734     +/-   ##
========================================
- Coverage    72.5%   72.5%   -0.1%     
========================================
  Files         279     279             
  Lines       11270   11306     +36     
  Branches     1237    1243      +6     
========================================
+ Hits         8178    8200     +22     
- Misses       2756    2764      +8     
- Partials      336     342      +6     
Flag Coverage Δ
#integrationtests 57.1% <71.4%> (+<0.1%) ⬆️
#unittests 66.4% <51.4%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...vices/sidecar/src/simcore_service_sidecar/utils.py 81.9% <46.6%> (-8.3%) ⬇️
...es/sidecar/src/simcore_service_sidecar/rabbitmq.py 90.1% <63.6%> (+0.4%) ⬆️
.../sidecar/src/simcore_service_sidecar/log_parser.py 81.8% <69.5%> (-5.9%) ⬇️
...es/sidecar/src/simcore_service_sidecar/executor.py 82.8% <85.0%> (-0.4%) ⬇️
...src/simcore_service_sidecar/celery_configurator.py 50.0% <87.5%> (-0.6%) ⬇️
...s/sidecar/src/simcore_service_sidecar/boot_mode.py 100.0% <100.0%> (ø)
...ervices/sidecar/src/simcore_service_sidecar/cli.py 66.6% <100.0%> (ø)
...ices/sidecar/src/simcore_service_sidecar/config.py 100.0% <100.0%> (ø)
...rvices/sidecar/src/simcore_service_sidecar/core.py 73.8% <100.0%> (-0.7%) ⬇️
...es/sidecar/src/simcore_service_sidecar/mpi_lock.py 25.9% <100.0%> (-1.4%) ⬇️
... and 1 more

@sanderegg sanderegg changed the title WIP: Bugfix/comp services see all inputs Bugfix/comp services see all inputs Aug 24, 2020
@sanderegg sanderegg marked this pull request as ready for review August 24, 2020 10:22
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor

@sanderegg sanderegg requested a review from pcrespov August 24, 2020 13:26
@pcrespov
Copy link
Member

It would be good to increase testing on this ...

@sanderegg sanderegg force-pushed the bugfix/comp_services_see_all_inputs branch from cc45cb0 to 0027b9a Compare August 24, 2020 21:30
@sanderegg sanderegg merged commit 60c6035 into ITISFoundation:master Aug 25, 2020
@sanderegg sanderegg deleted the bugfix/comp_services_see_all_inputs branch August 25, 2020 06:24
@sanderegg sanderegg mentioned this pull request Aug 25, 2020
@GitHK GitHK mentioned this pull request Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running some services is too slow logs are not uploaded from sidecar with services 1.0.0
3 participants