-
Notifications
You must be signed in to change notification settings - Fork 28
Bugfix/comp services see all inputs #1734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sanderegg
merged 26 commits into
ITISFoundation:master
from
sanderegg:bugfix/comp_services_see_all_inputs
Aug 25, 2020
Merged
Bugfix/comp services see all inputs #1734
sanderegg
merged 26 commits into
ITISFoundation:master
from
sanderegg:bugfix/comp_services_see_all_inputs
Aug 25, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1734 +/- ##
========================================
- Coverage 72.5% 72.5% -0.1%
========================================
Files 279 279
Lines 11270 11306 +36
Branches 1237 1243 +6
========================================
+ Hits 8178 8200 +22
- Misses 2756 2764 +8
- Partials 336 342 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
odeimaiz
approved these changes
Aug 24, 2020
pcrespov
requested changes
Aug 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor
pcrespov
approved these changes
Aug 24, 2020
It would be good to increase testing on this ... |
fix testing of sidecar
cc45cb0
to
0027b9a
Compare
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Bonus:
Related issue number
fixes #1723
How to test
Checklist
make openapi-specs
,git commit ...
and thenmake version-*
)