Skip to content

Feature#19/auth serve2 #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 48 commits into from
Aug 23, 2018
Merged

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jul 18, 2018


Web server adds authentication, sessions, db and APIs support
Implementing server-side of issue #19

Some new features:

  • enhances/extends docker, setup and testing infrastructure
  • service configuration (issue Configuration files in services #195)
  • adds server init, sessions, security and db support but still preserves same user level functionality.

@mguidon, @sanderegg

@pcrespov pcrespov requested a review from odeimaiz as a code owner July 18, 2018 15:00
@ghost ghost assigned pcrespov Jul 18, 2018
@ghost ghost added the review label Jul 18, 2018
@pcrespov pcrespov requested review from mguidon and sanderegg July 18, 2018 15:00
@pcrespov pcrespov mentioned this pull request Jul 18, 2018
7 tasks
Pedro Crespo added 14 commits July 18, 2018 18:05
 - created setup
 - updated travis-install
 - created docker-specific requirements
 - renamed docker into .docker
 -  sync install/test requires with req.txt
 - moved all source's module under src/server folder
 - moved mockups to tests
… - merge old/new style configs - added session - added authentication/authorization - added model - added config folder
 - simplified utils
 - moved init_db since it is a script and not a module
 - unsolved issue with base.txt
 - added logs and comments while running stand-alone in host
 - sync service configurations and server.config
 - merge db init and configuration
 - Added missing config settings via env in the webserver
@pcrespov pcrespov added this to the Libra milestone Aug 15, 2018
Pedro Crespo added 7 commits August 20, 2018 22:05
 - created a singleton for admin db engine
 - minor changes in api versioning format
 - avoid statics if do not exist but log issue
 - renamed server.config as config.settings
 - introduced schemas, validation and env-variable substitution
 - aded server.cli
 - defines entrypoint for cli: splits into cli, main and __main__ submodules
…dev/test setups in host/docker environments
log_level: DEBUG
port: 8080
testing: true
cs_s4l:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is probably not necessary in there... some leftover from the modeler code??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the moment, I leave it as it is (there are some variables defined for that in the current master version). I will cleanup afterwards. I added a note.

Pedro Crespo added 12 commits August 22, 2018 11:58
 - add schemas in all client-sdk configs (simcore_sdk.config.*)
 - renamed schema.py to config.py and reduced number of submodules
- adapted computational backend
 -  adapting fixtures to influence environment variables upon startup
 - extended config.rabbit
 - Fixed exposing ports in rabbit service
 -  Added sleep to tmp solve IncompatibleProtocolError exception upon pika.connect
@pcrespov pcrespov changed the title WIP: Feature#19/auth serve2 Feature#19/auth serve2 Aug 23, 2018
Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was only looking into how the configuration works. Looks good. I like the
await asyncio.sleep(5)
...

@pcrespov pcrespov merged commit b9788ce into ITISFoundation:master Aug 23, 2018
@ghost ghost removed the review label Aug 23, 2018
@pcrespov pcrespov deleted the feature#19/auth-serve2 branch September 18, 2018 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants