-
Notifications
You must be signed in to change notification settings - Fork 29
Fixed cached classifiers #1755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed cached classifiers #1755
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1755 +/- ##
========================================
- Coverage 71.7% 71.7% -0.1%
========================================
Files 302 302
Lines 11738 11738
Branches 1276 1276
========================================
- Hits 8421 8417 -4
- Misses 2972 2977 +5
+ Partials 345 344 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
It was also reported by @GitHK. Just created an issue for that: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue was fixed but I think there is more potential to improve the UX
Gave a couple of tips to think about ... but incomplete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR addresses the issue and I can correctly see label permissions now.
What do these changes do?
Fixes replicated classifiers.
The problem we have is that the current frontend cache is not able to handle classifiers coming from different organizations. This PR fixes this specific issue but it would be nice to extend the caching system.
Related issue number
closes ITISFoundation/osparc-issues#279
How to test
Checklist
make openapi-specs
,git commit ...
and thenmake version-*
)