Skip to content

Fixed cached classifiers #1755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 31, 2020
Merged

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Aug 28, 2020

What do these changes do?

Fixes replicated classifiers.

The problem we have is that the current frontend cache is not able to handle classifiers coming from different organizations. This PR fixes this specific issue but it would be nice to extend the caching system.

Related issue number

closes ITISFoundation/osparc-issues#279

How to test

Checklist

  • Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@codecov
Copy link

codecov bot commented Aug 28, 2020

Codecov Report

Merging #1755 into master will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1755     +/-   ##
========================================
- Coverage    71.7%   71.7%   -0.1%     
========================================
  Files         302     302             
  Lines       11738   11738             
  Branches     1276    1276             
========================================
- Hits         8421    8417      -4     
- Misses       2972    2977      +5     
+ Partials      345     344      -1     
Flag Coverage Δ
#integrationtests 56.8% <ø> (ø)
#unittests 65.7% <ø> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../simcore_service_webserver/projects/projects_db.py 82.3% <0.0%> (-1.1%) ⬇️
...ce_webserver/resource_manager/garbage_collector.py 68.6% <0.0%> (-0.9%) ⬇️

@odeimaiz odeimaiz changed the title fixed classifiers' cache Fixed cached classifiers Aug 28, 2020
@odeimaiz odeimaiz self-assigned this Aug 28, 2020
@odeimaiz odeimaiz added this to the Da Jia milestone Aug 28, 2020
@odeimaiz odeimaiz added the a:frontend issue affecting the front-end (area group) label Aug 28, 2020
@pcrespov
Copy link
Member

Cannot really see that the title here is actually a field ... Was confusing to find that therte was a field missing

image

@pcrespov
Copy link
Member

With such a huge tree, we would need some kind of search field at the top
image
Something like github

image

@odeimaiz
Copy link
Member Author

Cannot really see that the title here is actually a field ... Was confusing to find that therte was a field missing

image

It was also reported by @GitHK. Just created an issue for that:
ITISFoundation/osparc-issues#287

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue was fixed but I think there is more potential to improve the UX
Gave a couple of tips to think about ... but incomplete

@odeimaiz odeimaiz requested a review from GitHK August 31, 2020 08:39
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR addresses the issue and I can correctly see label permissions now.

@odeimaiz odeimaiz merged commit 493be5b into ITISFoundation:master Aug 31, 2020
@odeimaiz odeimaiz deleted the bugfix/classifiers branch November 26, 2020 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot assign items from multiple classifiers trees to a study
3 participants