-
Notifications
You must be signed in to change notification settings - Fork 28
Breadcrumb Navigation #1902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breadcrumb Navigation #1902
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's amazing how you managed to do this! Very nice... although the amount of code needed (svg library + your own) to create the breadcrumb splitter, I think it's too much. I wouldn't do this kind of personalised widgets too often.
Some little things:
- A controlled breadcrumb widget. Instead of having the logic in
NavigationBar
, having a separate Breadcrumb widget that takes a path of node ids, and renders itself as a series of ToggleButtons and separators, or even better, as a series of extended ToggleButtons that incorporate their separators when appropriate, and manage their state changes on hover, clicking, etc. - On hover, the separator is not highlighted and looks a bit weird.
- I don't know if related to this PR, but grouping nodes no longer works. Links created inside the group are not saved, and the edge stays dashed. I cannot ungroup them either..
- I see some hardcoded widths and heights
@GitHK @ignapas To be tackled in this PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ore into feature/breadcrumbs
What do these changes do?
This PR brings nicer a breadcrumb navigation plus some improvements in the slideshow viewer.
Related issue number
related to ITISFoundation/osparc-issues#327
closes ITISFoundation/osparc-issues#359
Workbench mode:

Guided mode:

Bonus:
How to test
Checklist
make openapi-specs
,git commit ...
and thenmake version-*
)