-
Notifications
You must be signed in to change notification settings - Fork 28
Adding image digests to databases #1914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1914 +/- ##
======================================
Coverage 72.7% 72.7%
======================================
Files 342 342
Lines 13019 13019
Branches 1383 1383
======================================
Hits 9474 9474
Misses 3162 3162
Partials 383 383
Flags with carried forward coverage won't be shown. Click here to find out more.
|
services/docker-compose.yml
Outdated
@@ -221,7 +221,7 @@ services: | |||
- default | |||
|
|||
postgres: | |||
image: postgres:10.11 | |||
image: postgres:10.11@sha256:b679ae588cb304011db5548af06d052a96c34867f80af81f1104162ef1f7ec6b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one question. is that SHA here forever? say this is 10.11.9. Say they overwrite 10.11.9 with a new image (not saying this will happen with postgres, but it already happened with some other images), what happens to this SHA? it will change. is the old one still available forever or does it get pruned out by the dockerhub registry when cleaning out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea behind the sha256 is that if they overwrite the 10.11 tag (because tags are mutable), the sha256 layer is still there and you can pull it. I don't think that docker hub deletes these layers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What do these changes do?
Ensure that the current version of the DB will not change if new versions are released or overwritten remotely.
Related issue number
How to test
Checklist
make openapi-specs
,git commit ...
and thenmake version-*
)