Skip to content

Adding image digests to databases #1914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 28, 2020
Merged

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Oct 27, 2020

What do these changes do?

Ensure that the current version of the DB will not change if new versions are released or overwritten remotely.

Related issue number

How to test

Checklist

  • Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #1914 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1914   +/-   ##
======================================
  Coverage    72.7%   72.7%           
======================================
  Files         342     342           
  Lines       13019   13019           
  Branches     1383    1383           
======================================
  Hits         9474    9474           
  Misses       3162    3162           
  Partials      383     383           
Flag Coverage Δ
#integrationtests 60.9% <ø> (+<0.1%) ⬆️
#unittests 66.0% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ce_webserver/resource_manager/garbage_collector.py 75.8% <0.0%> (-1.1%) ⬇️
...webserver/computation_comp_tasks_listening_task.py 87.6% <0.0%> (+2.2%) ⬆️

@@ -221,7 +221,7 @@ services:
- default

postgres:
image: postgres:10.11
image: postgres:10.11@sha256:b679ae588cb304011db5548af06d052a96c34867f80af81f1104162ef1f7ec6b
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question. is that SHA here forever? say this is 10.11.9. Say they overwrite 10.11.9 with a new image (not saying this will happen with postgres, but it already happened with some other images), what happens to this SHA? it will change. is the old one still available forever or does it get pruned out by the dockerhub registry when cleaning out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea behind the sha256 is that if they overwrite the 10.11 tag (because tags are mutable), the sha256 layer is still there and you can pull it. I don't think that docker hub deletes these layers.

@GitHK GitHK requested review from pcrespov and mguidon October 28, 2020 07:51
@GitHK GitHK marked this pull request as ready for review October 28, 2020 07:51
@GitHK GitHK self-assigned this Oct 28, 2020
@GitHK GitHK added a:infra+ops maintenance of infrastructure or operations (discussed in retro) t:enhancement Improvement or request on an existing feature labels Oct 28, 2020
@GitHK GitHK added this to the Shu milestone Oct 28, 2020
@GitHK GitHK requested a review from sanderegg October 28, 2020 10:42
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GitHK GitHK merged commit 4e7ca3c into ITISFoundation:master Oct 28, 2020
@sanderegg sanderegg mentioned this pull request Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:infra+ops maintenance of infrastructure or operations (discussed in retro) t:enhancement Improvement or request on an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants