-
Notifications
You must be signed in to change notification settings - Fork 29
Fixing duplicate key error in comp_pipeline #1934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1934 +/- ##
========================================
+ Coverage 72.2% 72.6% +0.4%
========================================
Files 326 351 +25
Lines 12807 13336 +529
Branches 1370 1391 +21
========================================
+ Hits 9249 9691 +442
- Misses 3187 3265 +78
- Partials 371 380 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
It made no sense to have a utility for this command. We need to remember the upset pattern |
pcrespov
approved these changes
Nov 5, 2020
services/web/server/src/simcore_service_webserver/computation_api.py
Outdated
Show resolved
Hide resolved
mguidon
approved these changes
Nov 5, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
A race condition occurs when updating the
comp_pipeline
and causes duplicate key errors. This will address the resolution of the race condition.Related issue number
How to test
Checklist
make openapi-specs
,git commit ...
and thenmake version-*
)