Skip to content

Fixing duplicate key error in comp_pipeline #1934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 5, 2020

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Nov 5, 2020

What do these changes do?

A race condition occurs when updating the comp_pipeline and causes duplicate key errors. This will address the resolution of the race condition.

Related issue number

How to test

Checklist

  • Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #1934 into master will increase coverage by 0.4%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1934     +/-   ##
========================================
+ Coverage    72.2%   72.6%   +0.4%     
========================================
  Files         326     351     +25     
  Lines       12807   13336    +529     
  Branches     1370    1391     +21     
========================================
+ Hits         9249    9691    +442     
- Misses       3187    3265     +78     
- Partials      371     380      +9     
Flag Coverage Δ
integrationtests 61.3% <100.0%> (-0.1%) ⬇️
unittests 66.0% <40.0%> (-0.9%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../director/src/simcore_service_director/producer.py 60.5% <100.0%> (ø)
...r/src/simcore_service_webserver/computation_api.py 77.5% <100.0%> (-0.5%) ⬇️
...webserver/computation_comp_tasks_listening_task.py 87.6% <0.0%> (-3.4%) ⬇️
...ore_service_director_v2/utils/client_decorators.py 69.2% <0.0%> (ø)
...imcore_service_director_v2/modules/remote_debug.py 28.5% <0.0%> (ø)
...mcore_service_director_v2/modules/docker_daemon.py 0.0% <0.0%> (ø)
...simcore_service_director_v2/models/schemas/meta.py 100.0% <0.0%> (ø)
...-v2/src/simcore_service_director_v2/core/errors.py 0.0% <0.0%> (ø)
...mcore_service_director_v2/models/schemas/errors.py 0.0% <0.0%> (ø)
...ervice_director_v2/api/dependencies/director_v0.py 100.0% <0.0%> (ø)
... and 27 more

@GitHK GitHK marked this pull request as ready for review November 5, 2020 13:14
@GitHK
Copy link
Contributor Author

GitHK commented Nov 5, 2020

It made no sense to have a utility for this command. We need to remember the upset pattern

@GitHK GitHK self-assigned this Nov 5, 2020
@GitHK GitHK added a:webserver issue related to the webserver service bug buggy, it does not work as expected labels Nov 5, 2020
@GitHK GitHK added this to the Wankel milestone Nov 5, 2020
@GitHK GitHK merged commit c8669fb into ITISFoundation:master Nov 5, 2020
@GitHK GitHK deleted the fix-dplicate-key-error branch November 5, 2020 13:51
@sanderegg sanderegg mentioned this pull request Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants