Skip to content

fix issues with PR#1877 #1964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Nov 17, 2020

What do these changes do?

should fix the code-climate issue in master CI build

Related issue number

How to test

Checklist

  • Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #1964 (4086d1f) into master (118ebad) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1964     +/-   ##
========================================
- Coverage    73.2%   73.2%   -0.1%     
========================================
  Files         372     372             
  Lines       13800   13800             
  Branches     1407    1407             
========================================
- Hits        10111   10110      -1     
  Misses       3316    3316             
- Partials      373     374      +1     
Flag Coverage Δ
integrationtests 63.3% <ø> (-0.1%) ⬇️
unittests 66.7% <ø> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ce_webserver/resource_manager/garbage_collector.py 77.6% <0.0%> (-1.0%) ⬇️
.../director/src/simcore_service_director/producer.py 60.6% <0.0%> (+0.2%) ⬆️

@sanderegg sanderegg requested review from GitHK and pcrespov November 17, 2020 09:18
@sanderegg sanderegg self-assigned this Nov 17, 2020
@sanderegg sanderegg added this to the Wankel milestone Nov 17, 2020
@sanderegg sanderegg requested a review from odeimaiz November 17, 2020 09:18
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bravo

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 hope this never shows again!

@sanderegg sanderegg merged commit ae0ae87 into ITISFoundation:master Nov 17, 2020
@sanderegg sanderegg deleted the is1877/bugfixes branch November 17, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants