Skip to content

Report errors during user cleanup #2013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Dec 1, 2020

What do these changes do?

Improves the workings of the GC to still continue cleaning if there are errors with some user and project data.

Related issue number

How to test

Checklist

  • Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@GitHK GitHK requested review from sanderegg and pcrespov and removed request for sanderegg December 1, 2020 16:50
@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #2013 (5beda2f) into master (5b01a28) will increase coverage by 1.7%.
The diff coverage is 50.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2013     +/-   ##
========================================
+ Coverage    72.0%   73.7%   +1.7%     
========================================
  Files         390     390             
  Lines       14346   14350      +4     
  Branches     1441    1441             
========================================
+ Hits        10335   10584    +249     
+ Misses       3650    3381    -269     
- Partials      361     385     +24     
Flag Coverage Δ
integrationtests 63.2% <50.0%> (+<0.1%) ⬆️
unittests 67.7% <50.0%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ce_webserver/resource_manager/garbage_collector.py 76.6% <50.0%> (-2.0%) ⬇️
...erver/src/simcore_service_webserver/director_v2.py 88.4% <0.0%> (+2.6%) ⬆️
...es/sidecar/src/simcore_service_sidecar/rabbitmq.py 89.7% <0.0%> (+4.4%) ⬆️
.../sidecar/src/simcore_service_sidecar/log_parser.py 81.8% <0.0%> (+16.8%) ⬆️
...ervices/sidecar/src/simcore_service_sidecar/cli.py 65.8% <0.0%> (+19.5%) ⬆️
...vices/sidecar/src/simcore_service_sidecar/utils.py 80.7% <0.0%> (+29.4%) ⬆️
services/sidecar/src/simcore_service_sidecar/db.py 92.0% <0.0%> (+40.0%) ⬆️
...rvices/sidecar/src/simcore_service_sidecar/core.py 71.4% <0.0%> (+46.6%) ⬆️
...es/sidecar/src/simcore_service_sidecar/executor.py 79.6% <0.0%> (+56.1%) ⬆️

@GitHK GitHK requested a review from pcrespov December 2, 2020 07:48
@GitHK GitHK changed the title GC will shuffle data before emoving it GC will shuffle data before removing it Dec 2, 2020
@GitHK GitHK changed the title GC will shuffle data before removing it Report errors during user cleanup Dec 3, 2020
@GitHK GitHK self-assigned this Dec 3, 2020
@GitHK GitHK added the bug buggy, it does not work as expected label Dec 3, 2020
@GitHK GitHK added this to the Alfred_Büchi milestone Dec 3, 2020
@GitHK GitHK added the a:webserver issue related to the webserver service label Dec 3, 2020
@GitHK GitHK merged commit 341a1e5 into ITISFoundation:master Dec 4, 2020
@GitHK GitHK deleted the enhancement-gc-shuffles-before-removing branch December 4, 2020 07:25
@sanderegg sanderegg mentioned this pull request Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants