-
Notifications
You must be signed in to change notification settings - Fork 29
API server rate limiting #2031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API server rate limiting #2031
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2031 +/- ##
======================================
Coverage 72.9% 72.9%
======================================
Files 421 421
Lines 15487 15487
Branches 1568 1568
======================================
+ Hits 11291 11296 +5
+ Misses 3789 3785 -4
+ Partials 407 406 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you create a helper with a client that produces a given request rate? That will help us tuning the limit we wish to have. Could add that e.g. in pytest-simcore/helpers
Yes I will try to have this in place. |
So I've added 2 utils to manually run when testing the rate limit of the service. Based on the parameters the test could run in seconds or in hours. If you have suggestions on how to transform it into a test I am listening. Also the parameters could be picked up from the |
What do these changes do?
Trying to add some rate limiting to the API server. This will filter based on the IP present in the
X-Forwarded-For
header added by Traefik.Note: this solution will not work on local deployments. All traffic is passing from the same IP.
Note2: the limit is very low. @pcrespov you might know better that me what to setup as limits.
Related issue number
How to test
Checklist
make openapi-specs
,git commit ...
and thenmake version-*
)